Skip to content

feat(experimental-utils): moved types eslint-plugin util to experimental-utils #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

feat(experimental-utils): moved types eslint-plugin util to experimental-utils #3317

wants to merge 23 commits into from

Conversation

detljh
Copy link

@detljh detljh commented Apr 27, 2021 •
edited by armano2
Loading

PR Checklist

Overview

Moves over the types util file into the experimental-utils package in eslint-utils

Also had to duplicate packages/eslint-plugin/typings/typescript.d.ts file into packages/experimental-utils/typings/typescript.d.ts as the types util file depended on it. Unsure if there's another way to do this?

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @detljh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement New feature or request label May 9, 2021
@bradzacher bradzacher changed the title chore(experimental-utils): moved types eslint-plugin util to experimental-utils feat(experimental-utils): moved types eslint-plugin util to experimental-utils May 9, 2021
bradzacher
bradzacher requested changes May 15, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - almost there - one suggestion.
Thanks for your contribution!

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label May 15, 2021
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 1, 2021
bradzacher
bradzacher requested changes Jun 6, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

One thing that you missed (I forgot this exists too!) is the test for the isUnsafeAssignment function:

https://github.com/detljh/typescript-eslint/blob/master/packages/eslint-plugin/tests/util/isUnsafeAssignment.test.ts

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jun 6, 2021
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 13, 2021
bradzacher
bradzacher previously approved these changes Jun 13, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher
Copy link
Member

looks like this needs to be rebased as there are some complex from another change.
once those are resolved we can merge this

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jun 13, 2021
lnguyenfln and others added 8 commits June 18, 2021 13:38
@lnguyenfln @detljh
chore(experimental-utils): moved types eslint-plugin util to experime…
137e3fd 
…ntal-utils package
@lnguyenfln @detljh
feat(experimental-utils): moved types eslint-plugin util to experimen…
9f4a4d6 
…tal-utils package
@lnguyenfln @detljh
feat(experimental-utils): moved types eslint-plugin util to experimen…
eea8ef6 
…tal-utils package
@lnguyenfln @detljh
feat(experimental-utils): moved types eslint-plugin util to experimen…
0a7893e 
…tal-utils package
@detljh
feat(experimental-utils): moved types eslint-plugin util to experimen…
13fdf56 
…tal-utils package
@detljh
feat(experimental-utils): moved types eslint-plugin util to experimen…
8fb132b 
…tal-utils
@detljh
Merge branch 'master' of https://github.com/detljh/typescript-eslint
dd7bce1
@lnguyenfln @detljh
feat(experimental-utils): moved types eslint-plugin util to experimen…
5ece2d9 
…tal-utils package
@nx-cloud
Copy link

nx-cloud bot commented Jun 29, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 09d5ee9. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 16 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 29, 2021
@bradzacher
Copy link
Member

Looks like there is a merge conflict and build failures.
Once that's fixed we can merge this in.
Thanks for all of your work on this!

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jul 31, 2021
@armano2 armano2 mentioned this pull request Dec 17, 2021
Merged
@netlify
Copy link

netlify bot commented Dec 17, 2021 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 09d5ee9

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61c245b95b0d4d00078439d4

@armano2 armano2 added blocked by another PR PRs which are ready to go but waiting on another PR and removed blocked by another PR PRs which are ready to go but waiting on another PR labels Dec 18, 2021
@armano2 armano2 requested a review from bradzacher December 21, 2021 21:24
@bradzacher
Copy link
Member

This was done in #3658 - a new package, @typescript-eslint/type-utils has been published!

@bradzacher bradzacher closed this Jan 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher Awaiting requested review from bradzacher

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Is the types util file exposed in the experimental-utils package?
4 participants
@detljh @bradzacher @armano2 @lnguyenfln