feat(eslint-plugin): add prefer-for-of rule #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule is intended to provide functionality equivalent to TSLint's prefer-for-of rule.
bradzacher
requested changes
Apr 6, 2019
|
Thanks for the review! Updated. While updating the README I also noticed I have the option of using type information, which would allow us to fix palantir/tslint#2021. Would it be worth it? |
|
@edsrzf - you could use the type information if you want. I don't know how necessary that is immediately considering that is a bit of an edge case. |
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=========================================
- Coverage 96.96% 96.87% -0.1%
=========================================
Files 69 70 +1
Lines 2572 2625 +53
Branches 408 424 +16
=========================================
+ Hits 2494 2543 +49
- Misses 46 49 +3
- Partials 32 33 +1
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule provides functionality equivalent to TSLint's prefer-for-of rule. Test cases are mostly taken from TSLint, but I added others that I thought of while implementing.
Note that this implementation still falls into palantir/tslint#2021, false positives on non-
Arrays that are still indexable and have alengthproperty, such as typed arrays. We'd need type-checking to do better than this.This is the first attempt I've made at writing a lint, so bear that in mind. 😄