Skip to content

chore(eslint-plugin): [no-loss-of-precision] fix spelling of isSeparatedNumeric #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2021
Merged

chore(eslint-plugin): [no-loss-of-precision] fix spelling of isSeparatedNumeric #3390

merged 2 commits into from
May 15, 2021

Conversation

tniessen
Copy link
Contributor

This commit fixes a typo in the name of the helper function isSeparatedNumeric.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tniessen!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

bradzacher
bradzacher approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher added the refactor PRs that refactor code only label May 15, 2021
@bradzacher bradzacher changed the title fix(eslint-plugin): rename isSeparatedNumeric chore(eslint-plugin): [no-loss-of-precision] fix spelling of isSeparatedNumeric May 15, 2021
@bradzacher bradzacher enabled auto-merge (squash) May 15, 2021 19:31
@codecov
Copy link

codecov bot commented May 15, 2021 •
edited
Loading

Codecov Report

Merging #3390 (06fce9d) into master (c80b5f2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3390   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files         318      318           
  Lines       11048    11048           
  Branches     3128     3128           
=======================================
  Hits        10259    10259           
  Misses        352      352           
  Partials      437      437
Flag Coverage Δ
unittest 92.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-loss-of-precision.ts 91.66% <100.00%> (ø)

@bradzacher bradzacher merged commit df7a0d6 into typescript-eslint:master May 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
@tniessen tniessen deleted the isSeparatedNumeric branch October 7, 2021 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
refactor PRs that refactor code only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tniessen @MichaelDeBoey @bradzacher