Skip to content

chore(experimental-utils): remove useless union types in ast-utils #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

chore(experimental-utils): remove useless union types in ast-utils #3419

merged 1 commit into from
May 28, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

Comment is a sub-type of Token

typescript-eslint/packages/ast-spec/src/unions/Token.ts

Lines 14 to 26 in 02acc4f

export type Token =
| BooleanToken
| Comment
| IdentifierToken
| JSXIdentifierToken
| JSXTextToken
| KeywordToken
| NullToken
| NumericToken
| PunctuatorToken
| RegularExpressionToken
| StringToken
| TemplateToken;

Follow-up of #3289

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@MichaelDeBoey MichaelDeBoey mentioned this pull request May 21, 2021
Merged
@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #3419 (84a6027) into master (02acc4f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3419   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files         318      318           
  Lines       11100    11100           
  Branches     3152     3152           
=======================================
  Hits        10288    10288           
  Misses        361      361           
  Partials      451      451
Flag Coverage Δ
unittest 92.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/experimental-utils/src/ast-utils/misc.ts 66.66% <ø> (ø)
...tal-utils/src/ast-utils/eslint-utils/predicates.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label May 24, 2021
bradzacher
bradzacher approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 25c45e2 into typescript-eslint:master May 28, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch May 29, 2021 01:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher