Skip to content

chore(eslint-plugin): remove useless union types #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 28, 2021
Merged

chore(eslint-plugin): remove useless union types #3421

merged 6 commits into from
May 28, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

Comment is a sub-type of Token

typescript-eslint/packages/ast-spec/src/unions/Token.ts

Lines 14 to 26 in 02acc4f

export type Token =
| BooleanToken
| Comment
| IdentifierToken
| JSXIdentifierToken
| JSXTextToken
| KeywordToken
| NullToken
| NumericToken
| PunctuatorToken
| RegularExpressionToken
| StringToken
| TemplateToken;

Follow-up of #3289

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 21, 2021 •
edited
Loading

Codecov Report

Merging #3421 (406ccc3) into master (ed4776a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3421   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         323      323           
  Lines       11139    11139           
  Branches     3158     3158           
=======================================
  Hits        10318    10318           
  Misses        365      365           
  Partials      456      456
Flag Coverage Δ
unittest 92.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/comma-spacing.ts 97.87% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 93.58% <ø> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts 100.00% <ø> (ø)
...lugin/src/rules/indent-new-do-not-use/TokenInfo.ts 100.00% <ø> (ø)
...es/eslint-plugin/src/rules/object-curly-spacing.ts 100.00% <ø> (ø)
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts 100.00% <100.00%> (ø)
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.13% <100.00%> (ø)

@MichaelDeBoey MichaelDeBoey mentioned this pull request May 21, 2021
Merged
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label May 24, 2021
bradzacher
bradzacher previously approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

bradzacher
bradzacher previously approved these changes May 28, 2021
View reviewed changes
@bradzacher bradzacher enabled auto-merge (squash) May 28, 2021 23:19
@bradzacher bradzacher disabled auto-merge May 28, 2021 23:34
@bradzacher bradzacher merged commit a760946 into typescript-eslint:master May 28, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-3 branch May 29, 2021 01:18
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 17, 2021
Merged
12 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher