Skip to content

chore: enable no-unsafe-return internally #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 31, 2021
Merged

chore: enable no-unsafe-return internally #3471

merged 8 commits into from
Jul 31, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 1, 2021 •
edited
Loading

Continues #3278.

no-unsafe-member-access had no violations. It had a bunch!

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 1, 2021 •
edited
Loading

Codecov Report

Merging #3471 (68778c8) into master (15f7184) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

❗ Current head 68778c8 differs from pull request most recent head c6a6a1f. Consider uploading reports for the commit c6a6a1f to get more accurate results

@@            Coverage Diff             @@
##           master    #3471      +/-   ##
==========================================
- Coverage   92.64%   92.63%   -0.02%     
==========================================
  Files         326      325       -1     
  Lines       11253    11317      +64     
  Branches     3171     3193      +22     
==========================================
+ Hits        10425    10483      +58     
- Misses        368      370       +2     
- Partials      460      464       +4
Flag Coverage Δ
unittest 92.63% <91.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/all.ts 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 98.27% <ø> (ø)
...eslint-plugin/src/rules/prefer-return-this-type.ts 90.47% <90.47%> (ø)
...es/eslint-plugin/src/rules/no-loss-of-precision.ts 91.66% <100.00%> (ø)
packages/eslint-plugin/src/util/astUtils.ts 89.47% <100.00%> (+7.65%) ⬆️
packages/visitor-keys/src/get-keys.ts
packages/visitor-keys/src/visitor-keys.ts

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jun 1, 2021
@bradzacher bradzacher marked this pull request as draft June 1, 2021 03:16
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: enable no-unsafe-member-access, no-unsafe-return internally chore: enable no-unsafe-return internally Jun 4, 2021
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 7, 2021 21:59
@nx-cloud
Copy link

nx-cloud bot commented Jun 17, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit c6a6a1f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/visitor-keys

Sent with 💌 from NxCloud.

@bradzacher bradzacher merged commit ce984e3 into typescript-eslint:master Jul 31, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-unsafe-member-access-return branch July 31, 2021 23:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher