Skip to content

chore: enabled no-unsafe-member-access internally #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 4, 2021

Continues #3278.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #3483 (c7646a2) into master (ce984e3) will increase coverage by 0.58%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3483      +/-   ##
==========================================
+ Coverage   92.63%   93.22%   +0.58%     
==========================================
  Files         325      291      -34     
  Lines       11327    10970     -357     
  Branches     3195     3144      -51     
==========================================
- Hits        10493    10227     -266     
+ Misses        370      281      -89     
+ Partials      464      462       -2     
Flag Coverage Δ
unittest 93.22% <0.00%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 98.27% <ø> (ø)
packages/typescript-estree/src/node-utils.ts 97.83% <0.00%> (ø)
...escript-estree/src/semantic-or-syntactic-errors.ts 87.50% <ø> (ø)
packages/typescript-estree/src/simple-traverse.ts 75.00% <ø> (ø)
.../experimental-utils/src/ts-eslint/ParserOptions.ts
packages/experimental-utils/src/json-schema.ts
...experimental-utils/src/ts-eslint-scope/Variable.ts
.../experimental-utils/src/ts-eslint-scope/analyze.ts
...xperimental-utils/src/ts-eslint-scope/Reference.ts
...l-utils/src/eslint-utils/batchedSingleLineTests.ts
... and 27 more

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jun 4, 2021
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 17, 2021 01:34
bradzacher
bradzacher previously approved these changes Jul 31, 2021
bradzacher
bradzacher previously approved these changes Jul 31, 2021
@bradzacher bradzacher merged commit 3db6532 into typescript-eslint:master Aug 1, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-unsafe-member-access branch August 1, 2021 00:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants