feat(typescript-estree): add support for custom module resolution #3516
Conversation
|
Thanks for the PR, @rdsedmundo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3516 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 326 326
Lines 11253 11263 +10
Branches 3171 3173 +2
=======================================
+ Hits 10425 10435 +10
Misses 368 368
Partials 460 460
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Nx Cloud ReportCI is running for commit a0b73fa. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
|
@bradzacher I have improved the test coverage since the CI ran, can you allow it to run again? Thanks. |
Fixes #2771
See #3514 (comment) for context on why simply using the
options.programsis not sufficient. tldr: when we pass a new program we have to re-implement a lot of what is already well done by the typescript-eslint team like caching and invalidating files properly.I'm not too familiar with the codebase, but I did my best to follow the standards from the files I touched. The implementation is on the basis of this comment of @bradzacher.