Skip to content

refactor(experimental-utils): simplify eslint-utils' predicate types in ast-utils #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2021
Merged

refactor(experimental-utils): simplify eslint-utils' predicate types in ast-utils #3550

merged 1 commit into from
Jun 20, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

Extracted the IsPunctuatorTokenWithValueFunction generic to get rid of all duplicates

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 17, 2021 •
edited
Loading

Codecov Report

Merging #3550 (dd77577) into master (ffbb3cf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3550   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files         325      325           
  Lines       11236    11236           
  Branches     3168     3168           
=======================================
  Hits        10409    10409           
  Misses        367      367           
  Partials      460      460
Flag Coverage Δ
unittest 92.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tal-utils/src/ast-utils/eslint-utils/predicates.ts 100.00% <100.00%> (ø)

@nx-cloud
Copy link

nx-cloud bot commented Jun 17, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit dd77577. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jun 17, 2021
bradzacher
bradzacher approved these changes Jun 20, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit e2e76a7 into typescript-eslint:master Jun 20, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-12 branch June 20, 2021 22:59
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 20, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher