Skip to content

docs(eslint-plugin): fix typo #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

docs(eslint-plugin): fix typo #3725

merged 1 commit into from
Aug 30, 2021

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Aug 10, 2021

"noted in the" was repeated in the text. Please refer the changes.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @brc-dd!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 10, 2021 •
edited
Loading

Codecov Report

Merging #3725 (9499c68) into master (db78642) will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
+ Coverage   92.68%   93.57%   +0.89%     
==========================================
  Files         327      147     -180     
  Lines       11351     7864    -3487     
  Branches     3201     2490     -711     
==========================================
- Hits        10521     7359    -3162     
+ Misses        369      161     -208     
+ Partials      461      344     -117
Flag Coverage Δ
unittest 93.57% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/definition/ImplicitGlobalVariableDefinition.ts
packages/scope-manager/src/lib/es2021.ts
...ages/scope-manager/src/lib/esnext.asynciterable.ts
...t-estree/src/create-program/useProvidedPrograms.ts
...ackages/scope-manager/src/scope/MappedTypeScope.ts
packages/experimental-utils/src/ast-utils/index.ts
packages/scope-manager/src/lib/es2016.full.ts
packages/scope-manager/src/variable/index.ts
...rimental-utils/src/ts-eslint-scope/ScopeManager.ts
...s/scope-manager/src/lib/es2020.symbol.wellknown.ts
... and 170 more

@nx-cloud
Copy link

nx-cloud bot commented Aug 10, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 9499c68. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

1 similar comment
@nx-cloud
Copy link

nx-cloud bot commented Aug 10, 2021

Nx Cloud Report

CI ran the following commands for commit 9499c68. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Aug 10, 2021
@bradzacher bradzacher changed the title docs(eslint-plugin): fix a small oversight, remove repeated text docs(eslint-plugin): fix typo Aug 30, 2021
bradzacher
bradzacher approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 921cbca into typescript-eslint:master Aug 30, 2021
@brc-dd brc-dd deleted the patch-1 branch August 30, 2021 08:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brc-dd @bradzacher