Skip to content

feat(eslint-plugin): [comma-dangle] align schema with ESLint v8 #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2021
Merged

feat(eslint-plugin): [comma-dangle] align schema with ESLint v8 #3768

merged 1 commit into from
Aug 21, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 21, 2021 •
edited
Loading

Continues #3738 by matching the rule's to the new ESLint value. Just on echange: adding an additionalProperties: false.

Refs: eslint/eslint#13739, eslint/eslint#14030

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: align comma-dangle to ESLin t8.x additionalProperties: false feat: align comma-dangle to ESLint 8.x additionalProperties: false Aug 21, 2021
@codecov
Copy link

codecov bot commented Aug 21, 2021 •
edited
Loading

Codecov Report

Merging #3768 (ea02900) into v5 (a752638) will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v5    #3768      +/-   ##
==========================================
+ Coverage   92.68%   93.57%   +0.89%     
==========================================
  Files         327      147     -180     
  Lines       11351     7864    -3487     
  Branches     3201     2490     -711     
==========================================
- Hits        10521     7359    -3162     
+ Misses        369      161     -208     
+ Partials      461      344     -117
Flag Coverage Δ
unittest 93.57% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/comma-dangle.ts 93.33% <ø> (ø)
...xperimental-utils/src/ts-eslint-scope/Reference.ts
packages/scope-manager/src/lib/index.ts
...mental-utils/src/eslint-utils/getParserServices.ts
packages/visitor-keys/src/get-keys.ts
...estree/src/create-program/createIsolatedProgram.ts
packages/scope-manager/src/lib/esnext.array.ts
packages/scope-manager/src/lib/es2019.array.ts
packages/scope-manager/src/lib/es2015.core.ts
packages/scope-manager/src/lib/es2018.ts
... and 171 more

@nx-cloud
Copy link

nx-cloud bot commented Aug 21, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit ea02900. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/scope-manager
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 21, 2021 18:18
@bradzacher bradzacher changed the title feat: align comma-dangle to ESLint 8.x additionalProperties: false feat(eslint-plugin): align comma-dangle to ESLint 8.x additionalProperties: false Aug 21, 2021
@bradzacher bradzacher added breaking change This change will require a new major version to be released enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels Aug 21, 2021
@bradzacher bradzacher added this to the 5.0.0 milestone Aug 21, 2021
@bradzacher bradzacher changed the base branch from master to v5 August 21, 2021 22:07
@bradzacher bradzacher changed the title feat(eslint-plugin): align comma-dangle to ESLint 8.x additionalProperties: false feat(eslint-plugin): [comma-dangle] align schema with ESLint v8 Aug 21, 2021
@bradzacher bradzacher merged commit cd7c33e into typescript-eslint:v5 Aug 21, 2021
@bradzacher bradzacher mentioned this pull request Aug 22, 2021
Closed
@JoshuaKGoldberg JoshuaKGoldberg deleted the comma-dangle-additional-properties branch August 22, 2021 16:18
This was referenced Aug 23, 2021
Draft
Closed
Closed
Closed
Merged
Closed
bradzacher pushed a commit that referenced this pull request Sep 3, 2021
@bradzacher
feat(eslint-plugin): [comma-dangle] align schema with ESLint v8 (#3768)
523ea7b
This was referenced Sep 4, 2021
Merged
Merged
Merged
@MichaelDeBoey MichaelDeBoey mentioned this pull request Sep 20, 2021
Closed
50 tasks
bradzacher pushed a commit that referenced this pull request Sep 21, 2021
@bradzacher
feat(eslint-plugin): [comma-dangle] align schema with ESLint v8 (#3768)
b8c57d1
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher