Skip to content

chore: enabled restrict-template-expressions internally #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2021
Merged

chore: enabled restrict-template-expressions internally #3854

merged 1 commit into from
Sep 20, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 7, 2021 •
edited
Loading

Second-to-last PR for #3278.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 7, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 10af98a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/experimental-utils

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Sep 7, 2021 •
edited
Loading

Codecov Report

Merging #3854 (10af98a) into master (4a88de2) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3854      +/-   ##
==========================================
- Coverage   92.70%   92.62%   -0.09%     
==========================================
  Files         329      310      -19     
  Lines       11534    10118    -1416     
  Branches     3257     2883     -374     
==========================================
- Hits        10693     9372    -1321     
+ Misses        368      312      -56     
+ Partials      473      434      -39
Flag Coverage Δ
unittest 92.62% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts 98.00% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts
...-estree/src/create-program/createProjectProgram.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/ts-estree/index.ts
...ript-estree/src/create-program/createSourceFile.ts
packages/typescript-estree/src/node-utils.ts
packages/typescript-estree/src/convert-comments.ts
...t-estree/src/create-program/useProvidedPrograms.ts
packages/typescript-estree/src/simple-traverse.ts
... and 10 more

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Sep 8, 2021
bradzacher
bradzacher approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 955d7a6 into typescript-eslint:master Sep 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the enable-restrict-template-expressions branch March 1, 2022 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaKGoldberg @MichaelDeBoey @bradzacher