Skip to content

docs(eslint-plugin): [no-unsafe-argument] fix grammar #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2021
Merged

docs(eslint-plugin): [no-unsafe-argument] fix grammar #3889

merged 2 commits into from
Oct 3, 2021

Conversation

lgenzelis
Copy link
Contributor

fixed grammar

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lgenzelis!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 14, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 4ec72ff. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/parser

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Sep 20, 2021
bradzacher
bradzacher requested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

The docs are all aligned with the rule defs - hence the CI failures.

We need to make these two additional changes:

  1. Update the rule spec

    typescript-eslint/packages/eslint-plugin/src/rules/no-unsafe-argument.ts

    Line 140 in 806eaac

    description: 'Disallows calling an function with an any type value',
  2. Run cd packages/eslint-plugin && yarn generate:rules-lists to update the root plugin readme

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Sep 20, 2021
@bradzacher bradzacher changed the title chore: fixes no-unsafe-argument.md grammar docs(eslint-plugin): [no-unsafe-argument] fix grammar Sep 20, 2021
@codecov
Copy link

codecov bot commented Sep 20, 2021 •
edited
Loading

Codecov Report

Merging #3889 (4ec72ff) into master (02c6ff3) will increase coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3889      +/-   ##
==========================================
+ Coverage   92.70%   93.51%   +0.81%     
==========================================
  Files         331      151     -180     
  Lines       11637     8143    -3494     
  Branches     3290     2582     -708     
==========================================
- Hits        10788     7615    -3173     
+ Misses        371      167     -204     
+ Partials      478      361     -117
Flag Coverage Δ
unittest 93.51% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts 85.22% <ø> (ø)
packages/scope-manager/src/referencer/Visitor.ts
...l-utils/src/ast-utils/eslint-utils/astUtilities.ts
...e-manager/src/definition/FunctionNameDefinition.ts
...mental-utils/src/eslint-utils/getParserServices.ts
packages/scope-manager/src/lib/es2018.regexp.ts
...pt-estree/src/create-program/createWatchProgram.ts
packages/scope-manager/src/lib/es2020.promise.ts
.../experimental-utils/src/ts-eslint/ParserOptions.ts
...experimental-utils/src/eslint-utils/RuleCreator.ts
... and 171 more

@lgenzelis
Copy link
Contributor Author

Done @bradzacher ! :)

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 3, 2021
bradzacher
bradzacher approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks so much for going the extra mile and fixing this!

@bradzacher bradzacher merged commit 3c773e4 into typescript-eslint:master Oct 3, 2021
@lgenzelis lgenzelis deleted the patch-2 branch October 4, 2021 11:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgenzelis @bradzacher