Skip to content

fix(eslint-plugin): no-object-literal-type-assertion: fix as const is reported #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2019
Merged

fix(eslint-plugin): no-object-literal-type-assertion: fix as const is reported #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b70c283
fix(eslint-plugin): no-object-literal-type-assertion: fix `as const` …
rhysd Mar 30, 2019
06f253a
Merge branch 'master' into fix-as-const
rhysd Apr 3, 2019
6c39274
Merge branch 'master' into fix-as-const
rhysd Apr 4, 2019
f396a69
Merge branch 'master' into fix-as-const
rhysd Apr 5, 2019
1f5e268
Merge branch 'master' into fix-as-const
JamesHenry Apr 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/eslint-plugin/src/rules/no-object-literal-type-assertion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ export default util.createRule<Options, MessageIds>({
case AST_NODE_TYPES.TSAnyKeyword:
case AST_NODE_TYPES.TSUnknownKeyword:
return false;
case AST_NODE_TYPES.TSTypeReference:
// Ignore `as const` and `<const>` (#166)
return (
node.typeName.type === AST_NODE_TYPES.Identifier &&
node.typeName.name !== 'const'
);
default:
return true;
}
Expand Down
2 changes: 2 additions & 0 deletions packages/eslint-plugin/tests/rules/no-object-literal-type-assertion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ ruleTester.run('no-object-literal-type-assertion', rule, {
// Allow cast to 'unknown'
`const foo = {} as unknown;`,
`const foo = <unknown> {};`,
`const foo = {} as const;`,
`const foo = <const> {};`,
{
code: `print({ bar: 5 } as Foo)`,
options: [
Expand Down