Skip to content

refactor(eslint-plugin): [no-shadow] use findVariable from utils #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2021
Merged

refactor(eslint-plugin): [no-shadow] use findVariable from utils #3921

merged 1 commit into from
Oct 3, 2021

Conversation

rafaelss95
Copy link
Contributor

Context: #3871 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rafaelss95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 23, 2021 •
edited
Loading

Codecov Report

Merging #3921 (46f1c89) into master (dda9cee) will decrease coverage by 0.01%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #3921      +/-   ##
==========================================
- Coverage   93.51%   93.49%   -0.02%     
==========================================
  Files         151      151              
  Lines        8144     8137       -7     
  Branches     2584     2582       -2     
==========================================
- Hits         7616     7608       -8     
  Misses        167      167              
- Partials      361      362       +1
Flag Coverage Δ
unittest 93.49% <94.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.33% <ø> (ø)
...nt-plugin/src/rules/no-unused-vars-experimental.ts 91.39% <ø> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 75.40% <75.00%> (-1.76%) ⬇️
...plugin/src/rules/explicit-module-boundary-types.ts 89.47% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts 100.00% <100.00%> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts 91.20% <100.00%> (+0.09%) ⬆️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 100.00% <100.00%> (ø)

@nx-cloud
Copy link

nx-cloud bot commented Sep 23, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 46f1c89. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/scope-manager
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/visitor-keys

Sent with 💌 from NxCloud.

1 similar comment
@nx-cloud
Copy link

nx-cloud bot commented Sep 23, 2021

Nx Cloud Report

CI ran the following commands for commit 46f1c89. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/scope-manager
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/visitor-keys

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Sep 23, 2021
bradzacher
bradzacher approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet - thanks for cleaning this up!

@bradzacher bradzacher merged commit 35a8acf into typescript-eslint:master Oct 3, 2021
@rafaelss95 rafaelss95 deleted the refactor/remove-duplication branch October 3, 2021 23:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelss95 @bradzacher