Skip to content

fix(eslint-plugin): [lines-between-class-members] fix exceptAfterOverload for abstract methods #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2021
Merged

fix(eslint-plugin): [lines-between-class-members] fix exceptAfterOverload for abstract methods #3943

merged 2 commits into from
Oct 3, 2021

Conversation

ixth
Copy link
Contributor

@ixth ixth commented Oct 1, 2021

Fixes #3942.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ixth!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Oct 1, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit cde6f08. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=build --all --parallel
#000000 nx prebuild @typescript-eslint/types
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Oct 1, 2021 •
edited
Loading

Codecov Report

Merging #3943 (cde6f08) into master (02c6ff3) will increase coverage by 0.81%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3943      +/-   ##
==========================================
+ Coverage   92.70%   93.51%   +0.81%     
==========================================
  Files         331      151     -180     
  Lines       11637     8143    -3494     
  Branches     3290     2582     -708     
==========================================
- Hits        10788     7615    -3173     
+ Misses        371      167     -204     
+ Partials      478      361     -117
Flag Coverage Δ
unittest 93.51% <100.00%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt-plugin/src/rules/lines-between-class-members.ts 85.71% <100.00%> (ø)
...es/scope-manager/src/scope/ConditionalTypeScope.ts
packages/scope-manager/src/scope/GlobalScope.ts
...estree/src/create-program/createIsolatedProgram.ts
packages/visitor-keys/src/visitor-keys.ts
packages/scope-manager/src/lib/es2017.ts
...ges/scope-manager/src/definition/TypeDefinition.ts
...ges/scope-manager/src/definition/DefinitionBase.ts
...e-manager/src/definition/TSEnumMemberDefinition.ts
...es/experimental-utils/src/ts-eslint-scope/Scope.ts
... and 171 more

@bradzacher bradzacher added the bug Something isn't working label Oct 3, 2021
bradzacher
bradzacher approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for being a champion and fixing this!

@bradzacher bradzacher merged commit 240fc65 into typescript-eslint:master Oct 3, 2021
This was referenced Nov 1, 2021
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lines-between-class-members] Enforces empty lines between overloads on abstract methods
2 participants
@ixth @bradzacher