Skip to content

feat(eslint-plugin): [no-shadow] exclude external type declaration merging #3959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 1, 2021
Merged

feat(eslint-plugin): [no-shadow] exclude external type declaration merging #3959

merged 6 commits into from
Nov 1, 2021

Conversation

idan-at
Copy link
Contributor

@idan-at idan-at commented Oct 4, 2021 •
edited by bradzacher
Loading

Lately (not sure exactly which version), this snippet started failing no the no-shadow rule:

import type { Foo } from 'bar';
declare module 'bar' {
  export interface Foo {
    x: string;
  }

It shouldn't fail, since this is the way to extend external types in typescript (there's no re-declaration here)

This PR fixes it.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @idan-at!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Oct 4, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit b85322f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx prebuild @typescript-eslint/types
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited
Loading

Codecov Report

Merging #3959 (a57c4a0) into master (7842090) will increase coverage by 0.26%.
The diff coverage is 90.00%.

❗ Current head a57c4a0 differs from pull request most recent head b85322f. Consider uploading reports for the commit b85322f to get more accurate results

@@            Coverage Diff             @@
##           master    #3959      +/-   ##
==========================================
+ Coverage   93.12%   93.39%   +0.26%     
==========================================
  Files         277      151     -126     
  Lines        9781     8103    -1678     
  Branches     2851     2572     -279     
==========================================
- Hits         9109     7568    -1541     
+ Misses        244      181      -63     
+ Partials      428      354      -74
Flag Coverage Δ
unittest 93.39% <90.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts 76.51% <90.00%> (+1.10%) ⬆️
packages/scope-manager/src/referencer/Reference.ts
packages/scope-manager/src/lib/es2019.string.ts
.../scope-manager/src/variable/ImplicitLibVariable.ts
packages/scope-manager/src/scope/CatchScope.ts
packages/scope-manager/src/lib/esnext.intl.ts
packages/scope-manager/src/lib/es2021.ts
...ckages/scope-manager/src/referencer/VisitorBase.ts
...e-manager/src/scope/FunctionExpressionNameScope.ts
packages/scope-manager/src/lib/esnext.symbol.ts
... and 117 more

@bradzacher bradzacher added the enhancement New feature or request label Oct 4, 2021
@bradzacher bradzacher changed the title fix(eslint-plugin): [no-shadow] exclude external type declaration mer… feat(eslint-plugin): [no-shadow] exclude external type declaration merging Oct 4, 2021
JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 16, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Just requesting changes on the dead-ish code: either getting rid of it or adding a test case to exercise it.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 16, 2021
@idan-at idan-at dismissed a stale review via 2b00d98 October 17, 2021 11:34
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 18, 2021
bradzacher
bradzacher approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect - thanks for thsi!

nice work making it so strict - this is amazing!

@bradzacher bradzacher merged commit a93cebf into typescript-eslint:master Nov 1, 2021
@idan-at idan-at deleted the no-shadow-external-merging branch November 1, 2021 08:30
This was referenced Nov 2, 2021
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rafaelss95 rafaelss95 rafaelss95 left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idan-at @JoshuaKGoldberg @bradzacher @rafaelss95