Skip to content

feat(experimental-utils): extract isTokenOfTypeWithConditions out of ast-utils' predicates #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

feat(experimental-utils): extract isTokenOfTypeWithConditions out of ast-utils' predicates #3977

merged 1 commit into from
Nov 1, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

#3976 needs to be merged first

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 6, 2021
Merged
@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #3977 (bf91a01) into master (9c8f9a8) will decrease coverage by 0.40%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #3977      +/-   ##
==========================================
- Coverage   93.07%   92.66%   -0.41%     
==========================================
  Files         295      194     -101     
  Lines       11069     8635    -2434     
  Branches     3218     2673     -545     
==========================================
- Hits        10302     8002    -2300     
+ Misses        299      255      -44     
+ Partials      468      378      -90
Flag Coverage Δ
unittest 92.66% <75.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/experimental-utils/src/ast-utils/helpers.ts 66.66% <60.00%> (ø)
...ges/experimental-utils/src/ast-utils/predicates.ts 91.11% <100.00%> (ø)
packages/scope-manager/src/lib/es2017.string.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
packages/scope-manager/src/lib/es2021.string.ts
packages/scope-manager/src/lib/es2015.proxy.ts
...pe-manager/src/scope/ClassFieldInitializerScope.ts
packages/scope-manager/src/lib/es2020.promise.ts
...ges/scope-manager/src/definition/TypeDefinition.ts
packages/scope-manager/src/scope/CatchScope.ts
... and 167 more

@nx-cloud
Copy link

nx-cloud bot commented Oct 6, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit bf91a01. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 14.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/parser

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the enhancement New feature or request label Oct 14, 2021
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review October 29, 2021 16:53
@MichaelDeBoey
Copy link
Contributor Author

@bradzacher Sorry for the delay, lots of ESLint plugins had some work 😅

bradzacher
bradzacher approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -thanks for this!

@bradzacher bradzacher merged commit 5229597 into typescript-eslint:master Nov 1, 2021
@redpeacock78 redpeacock78 mentioned this pull request Nov 2, 2021
Open
@MichaelDeBoey MichaelDeBoey deleted the patch-34 branch November 2, 2021 09:24
This was referenced Nov 3, 2021
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher