Skip to content

fix(eslint-plugin): ignore private identifiers in explicit-module-boundary-types #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

fix(eslint-plugin): ignore private identifiers in explicit-module-boundary-types #4046

merged 1 commit into from
Nov 1, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

PrivateIdentifier key nodes indicate it's a #.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #4046 (e501142) into master (f418f48) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4046   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files         152      152           
  Lines        8014     8016    +2     
  Branches     2568     2570    +2     
=======================================
+ Hits         7480     7482    +2     
  Misses        180      180           
  Partials      354      354
Flag Coverage Δ
unittest 93.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 89.40% <100.00%> (+0.14%) ⬆️

@nx-cloud
Copy link

nx-cloud bot commented Oct 25, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit e501142. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys

Sent with 💌 from NxCloud.

bradzacher
bradzacher approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice one

@bradzacher bradzacher merged commit 80b853d into typescript-eslint:master Nov 1, 2021
This was referenced Nov 2, 2021
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the explicit-boundary-private branch March 1, 2022 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[explicit-module-boundary-types] Explicit module boundary types expects private arrow function to be typed
2 participants
@JoshuaKGoldberg @bradzacher