-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: update to typescript 4.5-rc #4073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @sosukesuzuki! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
One test of typescript-estree fails maybe for microsoft/TypeScript#46577 |
/* | ||
* The semver package will ignore prerelease ranges, and we don't want to explicitly document every one | ||
* List them all separately here, so we can automatically create the full string | ||
*/ | ||
const SUPPORTED_PRERELEASE_RANGES: string[] = ['4.4.0-beta', '4.4.1-rc']; | ||
const SUPPORTED_PRERELEASE_RANGES: string[] = ['4.5.0-beta']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.5rc is out so we should add this
const SUPPORTED_PRERELEASE_RANGES: string[] = ['4.5.0-beta']; | |
const SUPPORTED_PRERELEASE_RANGES: string[] = ['4.5.0-beta', '4.5.1-rc']; |
I've updated tests to avoid microsoft/TypeScript#46577 (a3a89a7) |
Codecov Report
@@ Coverage Diff @@
## master #4073 +/- ##
=======================================
Coverage 92.73% 92.74%
=======================================
Files 334 334
Lines 11494 11494
Branches 3270 3270
=======================================
+ Hits 10659 10660 +1
Misses 362 362
+ Partials 473 472 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: 8026509 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/618a3965039b0e00089130c2 😎 Browse the preview: https://deploy-preview-4073--typescript-eslint.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
PR Checklist
Overview
updates to TypeScript 4.5 RC.
updates to TypeScript 4.5 Beta.I know typescript-eslint has the policy that is to implement new features when the RC version is released. The purpose of this pull request is to quickly add support for new features when the RC version is released. So this is still draft.