refactor: fix issue with building project under windows #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm command is not available in windows env
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 13 13
Lines 1724 1724
Branches 381 381
=======================================
Hits 1616 1616
Misses 56 56
Partials 52 52Continue to review full report at Codecov.
|
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
JamesHenry
pushed a commit
that referenced
this pull request
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i did some testing, and looks like on windows build is not possible now
rm command is not available in windows env