feat(eslint-plugin): extend eslint semi rule #411
Conversation
68d13ad to
646d44f
Compare
646d44f to
9d775d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
+ Coverage 97.14% 97.15% +<.01%
==========================================
Files 74 75 +1
Lines 2875 2885 +10
Branches 473 473
==========================================
+ Hits 2793 2803 +10
Misses 49 49
Partials 33 33
|
There was a problem hiding this comment.
Two things, otherwise looks good to me:
- please also update the ROADMAP.md so that it points at the new override rule instead of the base eslint rule
- please only document changes to the rule (if any) instead of copy-pasting the entire eslint docs.
- See this PR for an example: https://github.com/typescript-eslint/typescript-eslint/pull/311/files#diff-b2ed7b04fe6750d99a8a988bb2c011b2
a1976af to
8c5c1c9
Compare
|
Wait, @bradzacher what happened here? I went down PRs in reverse chronological order, so it is also partly my fault for not checking earlier contributions, but I have just merged a PR from you for this exact rule, despite you having approved an already open PR? |
|
I'm sorry for the confusion here @aprilrd I had no intention of missing our your contribution, thanks so much for taking the time to do it |
|
It is a bummer. If you would be so kind, I would like to understand the issues with this PR so that I can do better next time. |
|
Ahh crap, I'm so sorry about this. I was going through adding fixes for issues tagged as bug, noticed 3 issues for semi, and prioritised it; completely forgetting that there was this open PR that I'd already reviewed a few weeks ago. If you're willing - there's a few places that your PR can still contribute to this - specifically:
Again, I'm sorry that I slipped up here. |
|
I understand. I will make a separate pr with the readme and the test. |
Fixed #366, #123 and #409.
I plan on fixing #123 and #409 in this pr as well.