Skip to content

fix(visitor-keys): add missing import assertion keys #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

fix(visitor-keys): add missing import assertion keys #4178

merged 1 commit into from
Nov 18, 2021

Conversation

ota-meshi
Copy link
Contributor

PR Checklist

Overview

Add the missing key. This allows the rules to traverse the ImportAttribute.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 18, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: da9b024

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6195b8626b9e070008c55d4d

😎 Browse the preview: https://deploy-preview-4178--typescript-eslint.netlify.app

@nx-cloud
Copy link

nx-cloud bot commented Nov 18, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit da9b024. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/scope-manager

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Nov 18, 2021 •
edited
Loading

Codecov Report

Merging #4178 (da9b024) into master (84b4a8c) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4178      +/-   ##
==========================================
- Coverage   93.36%   93.15%   -0.22%     
==========================================
  Files         152      174      +22     
  Lines        8053     9652    +1599     
  Branches     2586     3019     +433     
==========================================
+ Hits         7519     8991    +1472     
- Misses        179      247      +68     
- Partials      355      414      +59
Flag Coverage Δ
unittest 93.15% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/simple-traverse.ts 75.00% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 81.34% <0.00%> (ø)
packages/typescript-estree/src/ts-estree/index.ts 100.00% <0.00%> (ø)
...pt-estree/src/create-program/createWatchProgram.ts 77.04% <0.00%> (ø)
packages/typescript-estree/src/ast-converter.ts 100.00% <0.00%> (ø)
...ckages/typescript-estree/src/jsx/xhtml-entities.ts 100.00% <0.00%> (ø)
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <0.00%> (ø)
packages/typescript-estree/src/node-utils.ts 97.72% <0.00%> (ø)
packages/typescript-estree/src/convert-comments.ts 100.00% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts 89.79% <0.00%> (ø)
... and 12 more

@bradzacher bradzacher added the bug Something isn't working label Nov 18, 2021
bradzacher
bradzacher approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant! thanks for doing this!

@bradzacher bradzacher merged commit 9c38b7f into typescript-eslint:master Nov 18, 2021
@bradzacher bradzacher mentioned this pull request Nov 18, 2021
Closed
8 tasks
@ota-meshi ota-meshi deleted the visitor-keys branch November 18, 2021 06:20
This was referenced Nov 30, 2021
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

visitorKeys does not contain assertions property.
2 participants
@ota-meshi @bradzacher