Skip to content

docs(website): optimize playground config editor #4242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2021
Merged

docs(website): optimize playground config editor #4242

merged 3 commits into from
Dec 9, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Nov 30, 2021 •
edited
Loading

PR Checklist

Overview

Playground config editor should now not trigger config update every time when you open/close it
few accessibility issues in modal has been fixed

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 30, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 9f6a899

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a7b9c74dc46a0007ece541

😎 Browse the preview: https://deploy-preview-4242--typescript-eslint.netlify.app

@armano2 armano2 added the documentation Documentation ("docs") that needs adding/updating label Nov 30, 2021
@nx-cloud
Copy link

nx-cloud bot commented Nov 30, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 9f6a899. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/visitor-keys
#000000 Node 16.x - nx test @typescript-eslint/typescript-estree
#000000 Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 16.x - nx prebuild @typescript-eslint/types
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/scope-manager

Sent with 💌 from NxCloud.

@bradzacher bradzacher merged commit f4b64c5 into main Dec 9, 2021
@bradzacher bradzacher deleted the docs/playground-config-optimization branch December 9, 2021 04:14
@armano2 armano2 self-assigned this Dec 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels
documentation Documentation ("docs") that needs adding/updating
Projects
No open projects
Website Playground
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher