Skip to content

docs(eslint-plugin): Mention useUnknownInCatchVariables in no-implicit-any-catch #4252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2021
Merged

docs(eslint-plugin): Mention useUnknownInCatchVariables in no-implicit-any-catch #4252

merged 1 commit into from
Dec 6, 2021

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Dec 6, 2021

PR Checklist

Overview

microsoft/TypeScript#41013 added useUnknownInCatchVariables which implies unknown instead of any, meaning this rule is actually wrong when when that's enabled (because it's no longer "implicit any catch")

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fregante!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 6, 2021 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 6f77aef

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61adae515cee1a00082b7c01

@nx-cloud
Copy link

nx-cloud bot commented Dec 6, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 6f77aef. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Dec 6, 2021 •
edited
Loading

Codecov Report

Merging #4252 (6f77aef) into main (9f58eab) will increase coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4252      +/-   ##
==========================================
+ Coverage   92.73%   93.35%   +0.61%     
==========================================
  Files         335      152     -183     
  Lines       11542     8056    -3486     
  Branches     3289     2590     -699     
==========================================
- Hits        10704     7521    -3183     
+ Misses        364      179     -185     
+ Partials      474      356     -118
Flag Coverage Δ
unittest 93.35% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/dom.iterable.ts
packages/scope-manager/src/lib/dom.ts
packages/scope-manager/src/lib/es2021.ts
packages/scope-manager/src/lib/es5.ts
packages/scope-manager/src/lib/index.ts
...ckages/scope-manager/src/lib/webworker.iterable.ts
packages/scope-manager/src/lib/webworker.ts
...ages/scope-manager/src/referencer/ExportVisitor.ts
...kages/scope-manager/src/scope/FunctionTypeScope.ts
...pe-manager/src/definition/CatchClauseDefinition.ts
... and 173 more

@fregante
Copy link
Contributor Author

fregante commented Dec 6, 2021

Damn that's a lot of bots 😂

@fregante fregante changed the title Mention useUnknownInCatchVariables in no-implicit-any-catch’s docs Docs: Mention useUnknownInCatchVariables in no-implicit-any-catch Dec 6, 2021
@fregante fregante changed the title Docs: Mention useUnknownInCatchVariables in no-implicit-any-catch docs(website): Mention useUnknownInCatchVariables in no-implicit-any-catch Dec 6, 2021
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Dec 6, 2021
@bradzacher bradzacher changed the title docs(website): Mention useUnknownInCatchVariables in no-implicit-any-catch docs(eslint-plugin): Mention useUnknownInCatchVariables in no-implicit-any-catch Dec 6, 2021
@bradzacher
Copy link
Member

thanks!

@bradzacher bradzacher merged commit 2306aca into typescript-eslint:main Dec 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fregante @bradzacher