Skip to content

feat(eslint-plugin): [restrict-plus-operand] add allowAny option #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 20, 2021
Merged

feat(eslint-plugin): [restrict-plus-operand] add allowAny option #4260

merged 11 commits into from
Dec 20, 2021

Conversation

lonyele
Copy link
Contributor

@lonyele lonyele commented Dec 6, 2021

PR Checklist

Overview

It allows any to be used with the current implementation that stringType such as any, string, bigint, number are possible to be added, but not with invalid types.

  1. I didn't introduce new warning messages because I couldn't think of good namings. I found that notNumbers catches all warnings thus used it here too.
  2. While tidying up if/else statement, code became if with return style, but if the code with if/else looks better, I'll
    change it.
  3. I reformatted docs to more recent style
  4. I couldn't push the code to feat(eslint-plugin): [restrict-plus-operands] add allowAny option #901, so I made a new one(again, sorry about the previous pr)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lonyele!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 6, 2021 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 578fa4b

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61ade7a8c861b20007f3b6bd

@nx-cloud
Copy link

nx-cloud bot commented Dec 6, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 578fa4b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Dec 6, 2021 •
edited
Loading

Codecov Report

Merging #4260 (578fa4b) into main (9f58eab) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4260      +/-   ##
==========================================
+ Coverage   92.73%   93.36%   +0.62%     
==========================================
  Files         335      152     -183     
  Lines       11542     8064    -3478     
  Branches     3289     2593     -696     
==========================================
- Hits        10704     7529    -3175     
+ Misses        364      179     -185     
+ Partials      474      356     -118
Flag Coverage Δ
unittest 93.36% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/restrict-plus-operands.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/dom.iterable.ts
packages/scope-manager/src/lib/dom.ts
packages/scope-manager/src/lib/es2021.ts
packages/scope-manager/src/lib/es5.ts
packages/scope-manager/src/lib/index.ts
...ckages/scope-manager/src/lib/webworker.iterable.ts
packages/scope-manager/src/lib/webworker.ts
...ages/scope-manager/src/referencer/ExportVisitor.ts
packages/scope-manager/src/lib/es2015.reflect.ts
... and 174 more

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Dec 9, 2021
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks! ✨

@bradzacher bradzacher merged commit 2788545 into typescript-eslint:main Dec 20, 2021
@lonyele lonyele mentioned this pull request Dec 20, 2021
Merged
3 tasks
@lonyele lonyele deleted the feature/add-allow-any-option branch December 20, 2021 12:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[restrict-plus-operands] Allowing any for summands
3 participants
@lonyele @JoshuaKGoldberg @bradzacher