Skip to content

docs(website): fix tsconfig.eslint.json instead of .eslintrc.js in code snippet #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2021
Merged

docs(website): fix tsconfig.eslint.json instead of .eslintrc.js in code snippet #4263

merged 2 commits into from
Dec 6, 2021

Conversation

dsanch3z
Copy link
Contributor

@dsanch3z dsanch3z commented Dec 6, 2021

PR Checklist

Overview

Use tsconfig.eslint.json instead of .eslint.js in the code snippet at /docs/linting/monorepo

The paragraph mentions a tsconfig.eslint.json file but the example is a javascript snippet named .eslintrc.js

Screen Shot 2021-12-06 at 13 05 16

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dsanch3z!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 6, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 58a7c07

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61ae61694010aa0008994e8f

😎 Browse the preview: https://deploy-preview-4263--typescript-eslint.netlify.app

armano2
armano2 previously approved these changes Dec 6, 2021
View reviewed changes
@nx-cloud
Copy link

nx-cloud bot commented Dec 6, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 58a7c07. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx prebuild @typescript-eslint/types
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx test @typescript-eslint/scope-manager

Sent with 💌 from NxCloud.

@armano2 armano2 added the documentation Documentation ("docs") that needs adding/updating label Dec 6, 2021
@bradzacher bradzacher changed the title docs(website): Fix tsconfig.eslint.json instead of .eslintrc.js in code snippet docs(website): fix tsconfig.eslint.json instead of .eslintrc.js in code snippet Dec 6, 2021
@bradzacher bradzacher merged commit 832b15a into typescript-eslint:main Dec 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsanch3z @armano2 @bradzacher