Skip to content

docs: updates to security rules in ROADMAP.md #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

docs: updates to security rules in ROADMAP.md #4271

merged 1 commit into from
Dec 7, 2021

Conversation

tosmolka
Copy link
Contributor

@tosmolka tosmolka commented Dec 7, 2021

Overview

This PR adds mapping for several security rules from tslint-microsoft-contrib to @microsoft/eslint-plugin-sdl, plus few minor clean-ups. Might be helpful for someone who still did not migrate over from TSLint.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tosmolka!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 7, 2021 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 15ab020

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61af514709b6db0007b12f9f

@nx-cloud
Copy link

nx-cloud bot commented Dec 7, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 15ab020. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys
#000000 Node 14.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx prebuild @typescript-eslint/types
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #4271 (15ab020) into main (72fa912) will increase coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4271      +/-   ##
==========================================
+ Coverage   92.75%   93.37%   +0.61%     
==========================================
  Files         336      152     -184     
  Lines       11577     8085    -3492     
  Branches     3296     2596     -700     
==========================================
- Hits        10738     7549    -3189     
+ Misses        366      181     -185     
+ Partials      473      355     -118
Flag Coverage Δ
unittest 93.37% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/scope/SwitchScope.ts
packages/scope-manager/src/lib/es2021.weakref.ts
...ages/scope-manager/src/referencer/ExportVisitor.ts
...perimental-utils/src/ts-eslint-scope/Referencer.ts
packages/scope-manager/src/lib/es2019.object.ts
...xperimental-utils/src/ts-eslint-scope/Reference.ts
...ages/scope-manager/src/lib/es2018.asynciterable.ts
...ackages/scope-manager/src/scope/MappedTypeScope.ts
packages/scope-manager/src/lib/es2017.string.ts
packages/typescript-estree/src/convert-comments.ts
... and 174 more

bradzacher
bradzacher approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this!

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Dec 7, 2021
@bradzacher
Copy link
Member

cc @JoshuaKGoldberg FYI

@bradzacher bradzacher merged commit 9c22f65 into typescript-eslint:main Dec 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tosmolka @bradzacher