Skip to content

chore: update codecov/codecov-action to v2 #4278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 9, 2021
Merged

chore: update codecov/codecov-action to v2 #4278

merged 4 commits into from
Dec 9, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Dec 9, 2021 •
edited
Loading

Overview

https://github.com/codecov/codecov-action#%EF%B8%8F--deprecration-of-v1

On February 1, 2022, this version will be fully sunset and no longer function

Due to the deprecation of the underlying bash uploader, the Codecov GitHub Action has released v2 which will use the new uploader. You can learn more about our deprecation plan and the new uploader on our blog.

We will be restricting any updates to the v1 Action to security updates and hotfixes.

This PR also fixes coverage report sent to codecov, we should submit coverage for all packages now

https://app.codecov.io/gh/typescript-eslint/typescript-eslint/compare/4278/tree/packages

new:
image

old:
image

@armano2 armano2 added the dependencies Issue about dependencies of the package label Dec 9, 2021
@typescript-eslint

This comment has been minimized.

Sign in to view
@netlify
Copy link

netlify bot commented Dec 9, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 7a29d08

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61b1674960f8ea0008418fb3

😎 Browse the preview: https://deploy-preview-4278--typescript-eslint.netlify.app

@nx-cloud
Copy link

nx-cloud bot commented Dec 9, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 7a29d08. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils

Sent with 💌 from NxCloud.

@armano2 armano2 marked this pull request as draft December 9, 2021 01:54
@codecov
Copy link

codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #4278 (7a29d08) into main (9c22f65) will decrease coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4278      +/-   ##
==========================================
- Coverage   93.37%   92.75%   -0.62%     
==========================================
  Files         152      336     +184     
  Lines        8085    11577    +3492     
  Branches     2596     3296     +700     
==========================================
+ Hits         7549    10738    +3189     
- Misses        181      366     +185     
- Partials      355      473     +118
Flag Coverage Δ
unittest 92.75% <ø> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/visitor-keys/src/visitor-keys.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2021.weakref.ts 100.00% <0.00%> (ø)
...es/experimental-utils/src/ts-eslint-scope/Scope.ts 100.00% <0.00%> (ø)
packages/typescript-estree/src/simple-traverse.ts 75.00% <0.00%> (ø)
packages/scope-manager/src/scope/BlockScope.ts 100.00% <0.00%> (ø)
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <0.00%> (ø)
packages/visitor-keys/src/get-keys.ts 100.00% <0.00%> (ø)
...ages/experimental-utils/src/ts-eslint/CLIEngine.ts 66.66% <0.00%> (ø)
...e-manager/src/definition/FunctionNameDefinition.ts 100.00% <0.00%> (ø)
...s/experimental-utils/src/eslint-utils/deepMerge.ts 89.47% <0.00%> (ø)
... and 174 more

@armano2 armano2 marked this pull request as ready for review December 9, 2021 02:16
@armano2 armano2 added repo maintenance things to do with maintenance of the repo, and not with code/docs and removed dependencies Issue about dependencies of the package labels Dec 9, 2021
@bradzacher bradzacher changed the title build: update codecov/codecov-action to v2 chore: update codecov/codecov-action to v2 Dec 9, 2021
bradzacher
bradzacher approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing - thanks!

@bradzacher bradzacher merged commit df18414 into main Dec 9, 2021
@bradzacher bradzacher deleted the codecov/codecov-action branch December 9, 2021 04:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher