Skip to content

fix(eslint-plugin): [no-implied-eval] improve performance #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2021
Merged

fix(eslint-plugin): [no-implied-eval] improve performance #4313

merged 2 commits into from
Dec 15, 2021

Conversation

mikeauclair
Copy link
Contributor

@mikeauclair mikeauclair commented Dec 15, 2021 •
edited
Loading

PR Checklist

Overview

Shifts the acquisition of type information in no-implied-eval down into the calleeName === FUNCTION_CONSTRUCTOR block because

  • That's the only place that it is consumed
  • Most nodes won't be function constructors (or zero will be if you're using no-new-func in the base eslint ruleset)

My team has been running this change (as a forked rule in our custom rules package) for a few days in CI on our fairly-large application and it's shaved ~25% off of over all runtime

@nx-cloud
Copy link

nx-cloud bot commented Dec 15, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit ee35742. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mikeauclair!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 15, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: ee35742

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61b9e2f018a9d200074e286a

😎 Browse the preview: https://deploy-preview-4313--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Dec 15, 2021 •
edited
Loading

Codecov Report

Merging #4313 (ee35742) into main (6626bd2) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4313      +/-   ##
==========================================
+ Coverage   93.92%   94.19%   +0.26%     
==========================================
  Files         174      152      -22     
  Lines        9689     8090    -1599     
  Branches     3019     2586     -433     
==========================================
- Hits         9100     7620    -1480     
+ Misses        354      266      -88     
+ Partials      235      204      -31
Flag Coverage Δ
unittest 94.19% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <100.00%> (ø)
...-estree/src/create-program/createDefaultProgram.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
packages/typescript-estree/src/simple-traverse.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
...pt-estree/src/create-program/createWatchProgram.ts
...-internal/src/rules/no-typescript-estree-import.ts
packages/typescript-estree/src/convert-comments.ts
...-estree/src/create-program/createProjectProgram.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
... and 13 more

@armano2 armano2 added performance Issues regarding performance package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Dec 15, 2021
bradzacher
bradzacher approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-implied-eval] Only get type information in the branch that consumes it fix(eslint-plugin): [no-implied-eval] improve performance Dec 15, 2021
@bradzacher bradzacher merged commit e344596 into typescript-eslint:main Dec 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin performance Issues regarding performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-implied-eval] Potential earlier exit for increased performance on large projects
3 participants
@mikeauclair @armano2 @bradzacher