Skip to content

docs: update links to point to correct pages #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2021
Merged

docs: update links to point to correct pages #4326

merged 1 commit into from
Dec 18, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Dec 18, 2021

PR Checklist

Overview

Update links to correctly point into troubleshooting and getting started pages

@armano2 armano2 added the documentation Documentation ("docs") that needs adding/updating label Dec 18, 2021
@armano2 armano2 self-assigned this Dec 18, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 18, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 878974c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 18, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 878974c

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61be0a87eb0b2300078d75ae

😎 Browse the preview: https://deploy-preview-4326--typescript-eslint.netlify.app

@armano2 armano2 changed the title docs: update links to point to correct packages docs: update links to point to correct pages Dec 18, 2021
@armano2
docs: update links to point to correct pages
878974c 
- affected links linting, troubleshooting
@armano2 armano2 force-pushed the doc/troubleshooting-links branch from e3c756b to 878974c Compare December 18, 2021 16:21
@codecov
Copy link

codecov bot commented Dec 18, 2021 •
edited
Loading

Codecov Report

Merging #4326 (878974c) into main (9f58eab) will increase coverage by 1.18%.
The diff coverage is 94.87%.

@@            Coverage Diff             @@
##             main    #4326      +/-   ##
==========================================
+ Coverage   92.73%   93.92%   +1.18%     
==========================================
  Files         335      174     -161     
  Lines       11542     9689    -1853     
  Branches     3289     3019     -270     
==========================================
- Hits        10704     9100    -1604     
+ Misses        364      354      -10     
+ Partials      474      235     -239
Flag Coverage Δ
unittest 93.92% <94.87%> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts 80.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 76.33% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 94.26% <93.33%> (+0.78%) ⬆️
...eslint-plugin/src/rules/consistent-type-exports.ts 97.70% <94.44%> (+1.86%) ⬆️
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <100.00%> (+2.94%) ⬆️
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 84.31% <100.00%> (+1.96%) ⬆️
...int-plugin/src/rules/strict-boolean-expressions.ts 98.81% <100.00%> (+0.03%) ⬆️
packages/eslint-plugin/src/rules/brace-style.ts 95.34% <0.00%> (ø)
... and 228 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heck yes

@JoshuaKGoldberg JoshuaKGoldberg merged commit 04d1f3e into main Dec 18, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the doc/troubleshooting-links branch December 18, 2021 23:20
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 30, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

@armano2 armano2

Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Getting Started links 404
2 participants
@armano2 @JoshuaKGoldberg