Skip to content

refactor(eslint-plugin): [restrict-plus-operands] add better error messages #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2022
Merged

refactor(eslint-plugin): [restrict-plus-operands] add better error messages #4332

merged 4 commits into from
Jan 17, 2022

Conversation

lonyele
Copy link
Contributor

@lonyele lonyele commented Dec 20, 2021

PR Checklist

Overview

came from here
I was going to change it to suggested notNumbersOrStrings naming, but as I think more about it like "what about bigint" or "what about any with invalid". I just made 2 error messages one for "invalid type case" and the other for "any with invalid type case". Still not super satisfied though. probably the limit of my English skill.

@nx-cloud
Copy link

nx-cloud bot commented Dec 20, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 2c5a46a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lonyele!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 20, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 2c5a46a

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e50d4c43170b00072ab1db

😎 Browse the preview: https://deploy-preview-4332--typescript-eslint.netlify.app

@lonyele lonyele mentioned this pull request Dec 20, 2021
Merged
3 tasks
@codecov
Copy link

codecov bot commented Dec 20, 2021 •
edited
Loading

Codecov Report

Merging #4332 (2c5a46a) into main (e61e388) will increase coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4332      +/-   ##
==========================================
+ Coverage   94.26%   94.61%   +0.34%     
==========================================
  Files         169      147      -22     
  Lines        9440     7842    -1598     
  Branches     2940     2508     -432     
==========================================
- Hits         8899     7420    -1479     
+ Misses        321      233      -88     
+ Partials      220      189      -31
Flag Coverage Δ
unittest 94.61% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/brace-style.ts 95.34% <ø> (ø)
...nt-plugin/src/rules/consistent-type-definitions.ts 97.29% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-exports.ts 97.70% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 94.26% <ø> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts 96.29% <ø> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts 97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/func-call-spacing.ts 96.87% <ø> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts 100.00% <ø> (ø)
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts 100.00% <ø> (ø)
...lugin/src/rules/indent-new-do-not-use/TokenInfo.ts 100.00% <ø> (ø)
... and 144 more

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Dec 21, 2021
bradzacher
bradzacher approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher merged commit 95aea18 into typescript-eslint:main Jan 17, 2022
@lonyele lonyele deleted the feat/better-error-message branch January 24, 2022 08:43
lonyele added a commit to lonyele/typescript-eslint that referenced this pull request Feb 12, 2022
@lonyele
refactor(eslint-plugin): [restrict-plus-operands] add better error me…
704c966 
…ssages (typescript-eslint#4332)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonyele @bradzacher