Skip to content

docs(website): use json5 library to parse config in playground #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2021
Merged

docs(website): use json5 library to parse config in playground #4341

merged 1 commit into from
Dec 23, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Dec 23, 2021

PR Checklist

Overview

use json5 library to parse config in playground

this allows users to provide js like structures that are not fully complaint with JSON

@armano2 armano2 added the documentation Documentation ("docs") that needs adding/updating label Dec 23, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 23, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 39bc14d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint

This comment has been minimized.

Sign in to view
@netlify
Copy link

netlify bot commented Dec 23, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 39bc14d

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61c458161ff67400072ed6d5

😎 Browse the preview: https://deploy-preview-4341--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #4341 (39bc14d) into main (0cd911a) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4341      +/-   ##
==========================================
+ Coverage   93.52%   93.89%   +0.37%     
==========================================
  Files         336      299      -37     
  Lines       11596    11222     -374     
  Branches     3291     3254      -37     
==========================================
- Hits        10845    10537     -308     
+ Misses        479      416      -63     
+ Partials      272      269       -3
Flag Coverage Δ
unittest 93.89% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rimental-utils/src/ast-utils/eslint-utils/index.ts
packages/experimental-utils/src/ts-eslint/Scope.ts
...perimental-utils/src/ts-eslint-scope/Referencer.ts
.../experimental-utils/src/ts-eslint/ParserOptions.ts
packages/experimental-utils/src/json-schema.ts
...-utils/src/ast-utils/eslint-utils/scopeAnalysis.ts
.../experimental-utils/src/eslint-utils/RuleTester.ts
...mental-utils/src/eslint-utils/getParserServices.ts
...ages/experimental-utils/src/ts-eslint/CLIEngine.ts
...mental-utils/src/ts-eslint-scope/PatternVisitor.ts
... and 27 more

@bradzacher bradzacher merged commit ba0b1e3 into main Dec 23, 2021
@bradzacher bradzacher deleted the website-playground-json5-config branch December 23, 2021 18:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2022
@armano2 armano2 self-assigned this May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels
documentation Documentation ("docs") that needs adding/updating
Projects
No open projects
Website Playground
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher