Skip to content

docs(eslint-plugin): mention constructor privacy limitation on no-useless-constructor #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2021
Merged

docs(eslint-plugin): mention constructor privacy limitation on no-useless-constructor #4377

merged 1 commit into from
Dec 31, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a ## Caveat heading in the rule docs file.

@nx-cloud
Copy link

nx-cloud bot commented Dec 31, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 738f644. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 31, 2021 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 738f644

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61ce64afbeb50800088c1bb2

@codecov
Copy link

codecov bot commented Dec 31, 2021 •
edited
Loading

Codecov Report

Merging #4377 (738f644) into main (4bb55a2) will increase coverage by 0.72%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main    #4377      +/-   ##
==========================================
+ Coverage   93.88%   94.61%   +0.72%     
==========================================
  Files         297      147     -150     
  Lines       11193     7841    -3352     
  Branches     3253     2507     -746     
==========================================
- Hits        10509     7419    -3090     
+ Misses        416      233     -183     
+ Partials      268      189      -79
Flag Coverage Δ
unittest 94.61% <76.92%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.30% <ø> (ø)
...ackages/eslint-plugin/src/util/getWrappingFixer.ts 100.00% <ø> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts 90.36% <57.14%> (-3.15%) ⬇️
...s/eslint-plugin/src/util/collectUnusedVariables.ts 93.19% <100.00%> (-0.03%) ⬇️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 100.00% <100.00%> (ø)
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts 75.00% <100.00%> (ø)
packages/eslint-plugin/src/util/misc.ts 93.33% <100.00%> (ø)
.../experimental-utils/src/eslint-utils/nullThrows.ts
packages/type-utils/src/isTypeReadonly.ts
packages/type-utils/src/propertyTypes.ts
... and 146 more

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Dec 31, 2021
bradzacher
bradzacher approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradzacher bradzacher changed the title docs: mention constructor privacy limitation on no-useless-constructor docs(eslint-plugin): mention constructor privacy limitation on no-useless-constructor Dec 31, 2021
@bradzacher bradzacher merged commit f936349 into typescript-eslint:main Dec 31, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the docs-useless-constructor-type-info branch January 1, 2022 03:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-useless-constructor] should not report on different constructor type
2 participants
@JoshuaKGoldberg @bradzacher