Skip to content

docs(eslint-plugin): [no-restricted-imports] fix incorrect "How to Use" configuration #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2022
Merged

docs(eslint-plugin): [no-restricted-imports] fix incorrect "How to Use" configuration #4394

merged 1 commit into from
Jan 7, 2022

Conversation

manovotny
Copy link
Contributor

A simple doc change as the current config incorrectly turned the rule off instead of error.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @manovotny!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jan 6, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 6ba2dfd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jan 6, 2022 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 6ba2dfd

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61d76ec0add3c00007904590

😎 Browse the preview: https://deploy-preview-4394--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #4394 (6ba2dfd) into main (8d710a0) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4394      +/-   ##
==========================================
+ Coverage   94.26%   94.61%   +0.34%     
==========================================
  Files         169      147      -22     
  Lines        9440     7841    -1599     
  Branches     2940     2507     -433     
==========================================
- Hits         8899     7419    -1480     
+ Misses        321      233      -88     
+ Partials      220      189      -31
Flag Coverage Δ
unittest 94.61% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/version-check.ts
...pt-estree/src/create-program/createWatchProgram.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
...t-estree/src/create-program/useProvidedPrograms.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
...ges/typescript-estree/src/create-program/shared.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
...ript-estree/src/create-program/createSourceFile.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/convert-comments.ts
... and 12 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) January 6, 2022 22:48
@manovotny
Copy link
Contributor Author

@JoshuaKGoldberg you bet! 👍

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Jan 7, 2022
@bradzacher bradzacher changed the title docs: fixes incorrect "How to Use" configuration for no-restricted-imports rule. docs(eslint-plugin): [no-restricted-imports] fix incorrect "How to Use" configuration Jan 7, 2022
@bradzacher bradzacher disabled auto-merge January 7, 2022 02:05
@bradzacher bradzacher changed the title docs(eslint-plugin): [no-restricted-imports] fix incorrect "How to Use" configuration Fixes incorrect "How to Use" for no-restricted-imports rule. Jan 7, 2022
@bradzacher bradzacher merged commit a294715 into typescript-eslint:main Jan 7, 2022
@bradzacher bradzacher changed the title Fixes incorrect "How to Use" for no-restricted-imports rule. docs(eslint-plugin): [no-restricted-imports] fix incorrect "How to Use" configuration Jan 7, 2022
bradzacher pushed a commit that referenced this pull request Jan 7, 2022
@manovotny @bradzacher
docs(eslint-plugin): [no-restricted-imports] fix incorrect "How to Us…
dd1bdce 
…e" configuration (#4394)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manovotny @JoshuaKGoldberg @bradzacher