Skip to content

fix(type-utils): isTypeReadonly now handles conditional types #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 17, 2022
Merged

fix(type-utils): isTypeReadonly now handles conditional types #4421

merged 16 commits into from
Jan 17, 2022

Conversation

RebeccaStevens
Copy link
Contributor

@RebeccaStevens RebeccaStevens commented Jan 9, 2022 •
edited
Loading

PR Checklist

Overview

isTypeReadonly now checks conditional types properly.

Note: This PR builds off #4416

@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 2b275e8. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jan 9, 2022 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 2b275e8

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e54bda2b6bcd00070cb973

@codecov
Copy link

codecov bot commented Jan 9, 2022 •
edited
Loading

Codecov Report

Merging #4421 (2b275e8) into main (ef3147c) will decrease coverage by 1.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4421      +/-   ##
==========================================
- Coverage   94.23%   92.68%   -1.55%     
==========================================
  Files         169      161       -8     
  Lines        9448     8151    -1297     
  Branches     2948     2616     -332     
==========================================
- Hits         8903     7555    -1348     
- Misses        321      396      +75     
+ Partials      224      200      -24
Flag Coverage Δ
unittest 92.68% <100.00%> (-1.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/type-utils/src/isTypeReadonly.ts 79.77% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-extra-semi.ts 54.54% <0.00%> (-12.13%) ⬇️
...lugin-internal/src/rules/plugin-test-formatting.ts
packages/typescript-estree/src/version-check.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/convert-comments.ts
...-internal/src/rules/no-typescript-estree-import.ts
...ript-estree/src/create-program/createSourceFile.ts
...-estree/src/create-program/createProjectProgram.ts
... and 28 more

@RebeccaStevens RebeccaStevens mentioned this pull request Jan 9, 2022
Merged
3 tasks
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks so much for this & the other issues+PRs @RebeccaStevens! Very much appreciated! 🚀

@bradzacher bradzacher added the bug Something isn't working label Jan 11, 2022
@RebeccaStevens RebeccaStevens mentioned this pull request Jan 12, 2022
Closed
@bradzacher
Copy link
Member

I merged your test PR first - just needs the conflict resolved and we can merge this!

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jan 17, 2022
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 17, 2022
@RebeccaStevens RebeccaStevens mentioned this pull request Jan 17, 2022
Merged
3 tasks
@bradzacher
Copy link
Member

man I hate how git handles these types of conflicts.
it's so truly horrible at them.

@bradzacher bradzacher merged commit 39a6806 into typescript-eslint:main Jan 17, 2022
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull request Feb 12, 2022
@RebeccaStevens @lonyele
fix(type-utils): isTypeReadonly now handles conditional types (typesc…
9f9498b 
…ript-eslint#4421)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
@RebeccaStevens RebeccaStevens deleted the issue-4420 branch March 10, 2023 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[isTypeReadonly] Conditional types are always marked as readonly
3 participants
@RebeccaStevens @bradzacher @JoshuaKGoldberg