Skip to content

docs: fix typo in comment #4445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2022
Merged

docs: fix typo in comment #4445

merged 1 commit into from
Jan 17, 2022

Conversation

pushkine
Copy link
Contributor

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Jan 16, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 3f30192. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @pushkine!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jan 16, 2022 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 3f30192

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e4469b19500d000783c5f8

@codecov
Copy link

codecov bot commented Jan 16, 2022 •
edited
Loading

Codecov Report

Merging #4445 (3f30192) into main (e61e388) will decrease coverage by 2.42%.
The diff coverage is 99.00%.

@@            Coverage Diff             @@
##             main    #4445      +/-   ##
==========================================
- Coverage   94.26%   91.84%   -2.43%     
==========================================
  Files         169      166       -3     
  Lines        9440     8340    -1100     
  Branches     2940     2659     -281     
==========================================
- Hits         8899     7660    -1239     
- Misses        321      482     +161     
+ Partials      220      198      -22
Flag Coverage Δ
unittest 91.84% <99.00%> (-2.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin-internal/src/rules/prefer-ast-types-enum.ts 91.30% <ø> (ø)
packages/eslint-plugin/src/rules/brace-style.ts 95.34% <ø> (ø)
...nt-plugin/src/rules/consistent-type-definitions.ts 97.29% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-exports.ts 97.70% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 94.26% <ø> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts 96.29% <ø> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts 97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/func-call-spacing.ts 96.87% <ø> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts 100.00% <ø> (ø)
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts 100.00% <ø> (ø)
... and 160 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) January 16, 2022 18:01
@JoshuaKGoldberg JoshuaKGoldberg changed the title typo docs: fix typo in comment Jan 16, 2022
@JoshuaKGoldberg
Copy link
Member

Blurgh, the Netlify deploy bug is back. Those failures are unrelated to this PR: #4335

bradzacher
bradzacher approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bradzacher bradzacher merged commit 253bfa3 into typescript-eslint:main Jan 17, 2022
@pushkine pushkine deleted the patch-1 branch January 17, 2022 15:15
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull request Feb 12, 2022
@pushkine @lonyele
docs: fix typo in comment (typescript-eslint#4445)
9136f90
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pushkine @JoshuaKGoldberg @bradzacher