Skip to content

docs: remove TEMPLATE from website; fix CSS autoprefixer warning #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

docs: remove TEMPLATE from website; fix CSS autoprefixer warning #4539

merged 1 commit into from
Feb 11, 2022

Conversation

Josh-Cena
Copy link
Member

PR Checklist

Overview

  1. This PR excludes TEMPLATE from the build entirely. Before it was listed in the sidebar's "deprecated" section which is definitely not correct; I think it doesn't make sense to put it anywhere in the website, so just removed it.
  2. This PR removes a Webpack module warning:
ModuleWarning [Warning: Warning

(9:3) autoprefixer: end value has mixed support, consider using flex-end instead] undefined
[WARNING] {"moduleIdentifier":"node_modules/babel-loader/lib/index.js??ruleSet[1].rules[5].use[0]!packages/website/src/components/config/ConfigEditor.tsx","moduleName":"./src/components/config/ConfigEditor.tsx","loc":"1:925-930","message":"export 'parse' (imported as 'parse') was not found in 'json5' (possible exports: default)","compilerPath":"server"}
<w> [webpack.cache.PackFileCacheStrategy] Skipped not serializable cache item 'mini-css-extract-plugin node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[7].use[1]!node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[7].use[2]!packages/website/src/components/FinancialContributors.module.css|0|Compilation/modules|node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[7].use[1]!node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[7].use[2]!packages/website/src/components/FinancialContributors.module.css': No serializer registered for Warning
<w> while serializing webpack/lib/cache/PackFileCacheStrategy.PackContentItems -> webpack/lib/NormalModule -> Array { 1 items } -> webpack/lib/ModuleWarning -> Warning

Since the container is flex anyways, there should be no visual changes.

@nx-cloud
Copy link

nx-cloud bot commented Feb 11, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit b6e0790. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Feb 11, 2022 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: b6e0790

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/62060de84c1a530008c6f26f

@Josh-Cena
Copy link
Member Author

Hmm, definitely something fishy with the Netlify build pipeline...😕

@codecov
Copy link

codecov bot commented Feb 11, 2022 •
edited
Loading

Codecov Report

Merging #4539 (b6e0790) into main (d698f6b) will increase coverage by 2.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4539      +/-   ##
==========================================
+ Coverage   92.49%   94.56%   +2.06%     
==========================================
  Files         346      147     -199     
  Lines       11696     7889    -3807     
  Branches     3340     2535     -805     
==========================================
- Hits        10818     7460    -3358     
+ Misses        608      234     -374     
+ Partials      270      195      -75
Flag Coverage Δ
unittest 94.56% <ø> (+2.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/ts-eslint/RuleTester.ts
...ckages/scope-manager/src/lib/webworker.iterable.ts
...ope-manager/src/definition/TSEnumNameDefinition.ts
packages/scope-manager/src/lib/es2021.weakref.ts
...ges/scope-manager/src/definition/TypeDefinition.ts
packages/utils/src/ts-eslint/SourceCode.ts
...estree/src/create-program/createIsolatedProgram.ts
packages/scope-manager/src/variable/Variable.ts
packages/scope-manager/src/lib/es2019.object.ts
...pt-estree/src/create-program/createWatchProgram.ts
... and 189 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I was wondering about the template showing up when I added it. And then missed it in the deprecated section 😄

Thanks for these touchups @Josh-Cena!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9d029a9 into typescript-eslint:main Feb 11, 2022
@Josh-Cena Josh-Cena deleted the jc/remove-template-webpage branch February 12, 2022 02:55
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull request Feb 12, 2022
@Josh-Cena @lonyele
docs: remove TEMPLATE from website; fix CSS autoprefixer warning (typ…
3913378 
…escript-eslint#4539)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @JoshuaKGoldberg