Skip to content

chore: remove unsupported branch argument from update-sponsors #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2022
Merged

chore: remove unsupported branch argument from update-sponsors #4546

merged 2 commits into from
Feb 14, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Turns out schedule (cron) in GHA doesn't support specifying the branch. https://github.com/typescript-eslint/typescript-eslint/actions/runs/1834719537

Error: .github#L1
Invalid type for `on`

Per https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule the commit SHA will be the last commit on the default branch.

@nx-cloud
Copy link

nx-cloud bot commented Feb 12, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 9e5d616. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Feb 12, 2022 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 9e5d616

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/620817764c40d6000700e298

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 12, 2022
Closed
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Feb 14, 2022
@bradzacher bradzacher merged commit 29c0799 into typescript-eslint:main Feb 14, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the update-sponsors-branch branch February 14, 2022 07:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate missing "financial contributors" section contents
2 participants
@JoshuaKGoldberg @bradzacher