Skip to content

docs(eslint-plugin): [member-ordering] correct options type #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

docs(eslint-plugin): [member-ordering] correct options type #4568

merged 1 commit into from
Feb 17, 2022

Conversation

fiahfy
Copy link
Contributor

@fiahfy fiahfy commented Feb 17, 2022

PR Checklist

Overview

Corrected member-ordering options type on the readme.

@nx-cloud
Copy link

nx-cloud bot commented Feb 17, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 7b2e28d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fiahfy!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Feb 17, 2022

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 7b2e28d

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/620e0c2db64f99000793b92a

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #4568 (7b2e28d) into main (b83f597) will increase coverage by 1.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4568      +/-   ##
==========================================
+ Coverage   92.84%   94.61%   +1.77%     
==========================================
  Files         306      147     -159     
  Lines       11303     7912    -3391     
  Branches     3300     2540     -760     
==========================================
- Hits        10494     7486    -3008     
+ Misses        546      234     -312     
+ Partials      263      192      -71     
Flag Coverage Δ
unittest 94.61% <ø> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/es2020.promise.ts
packages/scope-manager/src/ScopeManager.ts
...ages/scope-manager/src/lib/es2018.asynciterable.ts
packages/scope-manager/src/lib/es2015.core.ts
packages/scope-manager/src/lib/esnext.intl.ts
packages/scope-manager/src/lib/es5.ts
packages/scope-manager/src/analyze.ts
packages/scope-manager/src/lib/es2017.intl.ts
packages/scope-manager/src/scope/ModuleScope.ts
...ackages/scope-manager/src/lib/es2015.collection.ts
... and 149 more

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Feb 17, 2022
@bradzacher bradzacher changed the title docs(eslint-plugin): correct member-ordering options type docs(eslint-plugin): [member-ordering] correct options type Feb 17, 2022
@bradzacher bradzacher merged commit cc71766 into typescript-eslint:main Feb 17, 2022
@fiahfy fiahfy deleted the feature/member_ordering branch February 18, 2022 01:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants