Skip to content

docs: add a missing " #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

ann-kilzer
Copy link
Contributor

PR Checklist

Overview

The documentation is missing a " and I'm trying to fix it.

Happy to file an issue if you think it's worth it, but didn't want to add more noise.

@nx-cloud
Copy link

nx-cloud bot commented Feb 20, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 2bef29c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ann-kilzer!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Feb 20, 2022

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 2bef29c

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/62121e18df5b1c00074a286c

@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #4577 (2bef29c) into main (b83f597) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4577      +/-   ##
==========================================
- Coverage   92.84%   92.79%   -0.05%     
==========================================
  Files         306      163     -143     
  Lines       11303     8271    -3032     
  Branches     3300     2654     -646     
==========================================
- Hits        10494     7675    -2819     
+ Misses        546      396     -150     
+ Partials      263      200      -63     
Flag Coverage Δ
unittest 92.79% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/es2021.intl.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
...es/scope-manager/src/scope/ConditionalTypeScope.ts
packages/scope-manager/src/lib/webworker.ts
packages/scope-manager/src/lib/es2019.symbol.ts
...lugin-internal/src/rules/plugin-test-formatting.ts
packages/scope-manager/src/lib/es6.ts
.../scope-manager/src/variable/ImplicitLibVariable.ts
packages/scope-manager/src/lib/es2016.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
... and 137 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha nice catch, thanks @ann-kilzer!

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: Add a missing " docs: add a missing " Feb 20, 2022
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) February 20, 2022 17:50
@bradzacher bradzacher disabled auto-merge February 21, 2022 04:43
@bradzacher bradzacher changed the title docs: add a missing " Add a missing " Feb 21, 2022
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Feb 21, 2022
@bradzacher bradzacher changed the title Add a missing " docs: add a missing " Feb 21, 2022
@bradzacher bradzacher merged commit 0dd785f into typescript-eslint:main Feb 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants