Skip to content

feat: TypeScript 4.6 #4615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 4, 2022
Merged

feat: TypeScript 4.6 #4615

merged 5 commits into from
Mar 4, 2022

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Mar 1, 2022 •
edited by bradzacher
Loading

PR Checklist

Sorry I have not created an issue for this.

Overview

TypeScript 4.6 has been released:tada:

This PR updates typescript to 4.6.

Also, fixes some tests for typescript-estree to match the fixes on the TypeScript side.

@nx-cloud
Copy link

nx-cloud bot commented Mar 1, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 361c98f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 52 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 1, 2022 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 361c98f

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/62215e001957f30008157a58

@codecov
Copy link

codecov bot commented Mar 1, 2022 •
edited
Loading

Codecov Report

Merging #4615 (361c98f) into main (4ed686f) will decrease coverage by 2.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4615      +/-   ##
==========================================
- Coverage   94.23%   92.00%   -2.24%     
==========================================
  Files         151      350     +199     
  Lines        7948    11621    +3673     
  Branches     2572     3375     +803     
==========================================
+ Hits         7490    10692    +3202     
- Misses        262      660     +398     
- Partials      196      269      +73
Flag Coverage Δ
unittest 92.00% <100.00%> (-2.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/dom.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/dom.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/esnext.array.ts 100.00% <ø> (ø)
...ckages/scope-manager/src/lib/webworker.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/webworker.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2022.array.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.error.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.full.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.object.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.string.ts 100.00% <100.00%> (ø)
... and 196 more

bradzacher
bradzacher requested changes Mar 1, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you also please run yarn generate:lib within typescript-estree?

typescript-eslint/packages/scope-manager/package.json

Line 36 in 3ea0947

"generate:lib": "../../node_modules/.bin/ts-node --files --transpile-only tools/generate-lib.ts",

bradzacher
bradzacher reviewed Mar 1, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also just bump the peer dep ranges as there's no new features to handle from our side (according to the change log)

@F3n67u F3n67u mentioned this pull request Mar 2, 2022
Closed
@sosukesuzuki
Copy link
Contributor Author

@bradzacher

We can also just bump the peer dep ranges as there's no new features to handle from our side (according to the change log)

Sorry what does "peer dep ranges" mean?

bradzacher
bradzacher previously approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@bradzacher
Copy link
Member

OOPS! Missed your comment.

Sorry what does "peer dep ranges" mean?

Should just be this right here:

typescript-eslint/packages/typescript-estree/src/parser.ts

Line 33 in 56a09e9

const SUPPORTED_TYPESCRIPT_VERSIONS = '>=3.3.1 <4.6.0';

This is where we validate the TS version you're using. I forgot that we don't actually have a hard peer dependency range for TS in the package (they're all "*")

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Mar 2, 2022
@bradzacher bradzacher changed the title chore: update to TypeScript 4.6 feat: update to TypeScript 4.6 Mar 2, 2022
@bradzacher bradzacher self-requested a review March 2, 2022 18:27
@bradzacher bradzacher dismissed their stale review March 2, 2022 18:27

needs one change

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Mar 2, 2022
@sosukesuzuki
Copy link
Contributor Author

Why netlify on CI was failed..?

@bradzacher
Copy link
Member

It's not your fault. The build is just flaky.

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Mar 4, 2022
bradzacher
bradzacher approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@bradzacher bradzacher changed the title feat: update to TypeScript 4.6 feat: TypeScript 4.6 Mar 4, 2022
@bradzacher bradzacher merged commit a02c63a into typescript-eslint:main Mar 4, 2022
@sosukesuzuki sosukesuzuki deleted the update-ts-4.6 branch March 4, 2022 05:13
@nemchik nemchik mentioned this pull request Mar 4, 2022
Closed
@haseebanwar haseebanwar mentioned this pull request Mar 9, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosukesuzuki @bradzacher