Skip to content

fix(utils): RuleTester: Only call afterAll if defined #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2022
Merged

fix(utils): RuleTester: Only call afterAll if defined #4656

merged 2 commits into from
Mar 18, 2022

Conversation

ArnaudBarre
Copy link
Contributor

@ArnaudBarre ArnaudBarre commented Mar 9, 2022 •
edited
Loading

When using RuleTester outside of a test runner, if fails to instantiate due to ReferenceError: afterAll is not defined.
This PR make it possible to use TS ESLint RuleTester in simple node scripts.

@nx-cloud
Copy link

nx-cloud bot commented Mar 9, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit b1cd4be. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ArnaudBarre!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 9, 2022 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: b1cd4be

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6228be4991333900080f80d8

😎 Browse the preview: https://deploy-preview-4656--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Mar 9, 2022 •
edited
Loading

Codecov Report

Merging #4656 (b1cd4be) into main (cf325ce) will decrease coverage by 2.47%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4656      +/-   ##
==========================================
- Coverage   94.25%   91.77%   -2.48%     
==========================================
  Files         151      202      +51     
  Lines        7971     8819     +848     
  Branches     2573     2778     +205     
==========================================
+ Hits         7513     8094     +581     
- Misses        262      514     +252     
- Partials      196      211      +15
Flag Coverage Δ
unittest 91.77% <0.00%> (-2.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/eslint-utils/RuleTester.ts 11.36% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts 90.90% <0.00%> (ø)
packages/type-utils/src/getSourceFileOfNode.ts 0.00% <0.00%> (ø)
packages/type-utils/src/typeFlagUtils.ts 83.33% <0.00%> (ø)
packages/utils/src/eslint-utils/deepMerge.ts 89.47% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Reference.ts 100.00% <0.00%> (ø)
packages/type-utils/src/propertyTypes.ts 90.00% <0.00%> (ø)
packages/type-utils/src/getTokenAtPosition.ts 0.00% <0.00%> (ø)
packages/utils/src/eslint-utils/RuleCreator.ts 75.00% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Scope.ts 100.00% <0.00%> (ø)
... and 42 more

@bradzacher bradzacher added the bug Something isn't working label Mar 10, 2022
bradzacher
bradzacher approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see why not!
thanks for this!

@bradzacher bradzacher merged commit 0fe0683 into typescript-eslint:main Mar 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnaudBarre @bradzacher