Skip to content

chore: add --changedSince to CI test runs on other Node.js versions #4661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

chore: add --changedSince to CI test runs on other Node.js versions #4661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cb73516
chore: add --changedSince to CI test runs on other Node.js versions
JoshuaKGoldberg Mar 9, 2022
86bb14f
chore: add --changedSince to CI test runs on other Node.js versions
JoshuaKGoldberg Mar 9, 2022
9d6d0e4
chore: remove unnecessary tests comment from unified-signatures
JoshuaKGoldberg Mar 9, 2022
d1673b4
chore: reduce to just eslint-plugin
JoshuaKGoldberg Mar 10, 2022
6362806
chore: try one-liner to fetch commits from origin
JoshuaKGoldberg Mar 10, 2022
0b20918
chore: add back populating base SHA
JoshuaKGoldberg Mar 10, 2022
7e21221
chore: fix pulling base SHA
JoshuaKGoldberg Mar 10, 2022
8ddf512
chore: try pulling instead of fetching
JoshuaKGoldberg Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,24 @@ jobs:
# Added the - at the end to function as a separator to improve readability in the PR comment from the Nx cloud app
NX_CLOUD_ENV_NAME: 'Node ${{ matrix.node-version }} -'
steps:
- name: Populate base SHA in local history
uses: actions/checkout@v3
with:
fetch-depth: 1
ref: ${{ github.event.pull_request.base.sha }}

- uses: actions/checkout@v3
with:
fetch-depth: 2

- name: Print debug Git info
run: |
git remote -v
git log

- name: Pull commits after base SHA
run: git log ${{ github.event.pull_request.base.sha }}.. --pretty="%H" | xargs -n1 git pull origin

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand Down Expand Up @@ -299,7 +316,7 @@ jobs:
CI: true

- name: Run unit tests for eslint-plugin
run: npx nx test @typescript-eslint/eslint-plugin
run: npx nx test @typescript-eslint/eslint-plugin --changedSince=${{ github.event.pull_request.base.sha }}
env:
CI: true

Expand Down
4 changes: 0 additions & 4 deletions packages/eslint-plugin/tests/rules/unified-signatures.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import rule from '../../src/rules/unified-signatures';
import { RuleTester } from '../RuleTester';

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester({ parser: '@typescript-eslint/parser' });

ruleTester.run('unified-signatures', rule, {
Expand Down