Skip to content

chore: Bump @swc/core from 1.2.154 to 1.2.155 #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2022
Merged

chore: Bump @swc/core from 1.2.154 to 1.2.155 #4683

merged 3 commits into from
Mar 20, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 14, 2022 •
edited
Loading

Bumps @swc/core from 1.2.154 to 1.2.155.

Changelog

Sourced from @​swc/core's changelog.

[1.2.155] - 2022-03-14

Bug Fixes

  • (common) Don't use None as source while generating source maps (#4007) (0ad13d9)

  • (css/codegen) Fix source maps (#3997) (ece8d96)

  • (es) Merge jsc.loose and jsc.assumptions (#3990) (3590ea2)

  • (es/resolver) Use correct context for identifiers after type parameters (#4000) (87a3c1c)

Documentation

  • (api/rust) Add examples (#4002) (dac84b9)

  • (api/rust) Add an example for generating code and sourcemap (#4005) (f650ca6)

Features

Miscellaneous Tasks

  • (ci) Invoke yarn before publishing (743a5da)

  • (es/preset-env) Track .json files to make cargo happy (bd0fcb9)- general: Update linguist (#3991) (0312292)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Issue about dependencies of the package javascript Pull requests that update Javascript code labels Mar 14, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 14, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 33760f1. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dependabot[bot]!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 33760f1

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/62375e7c0d9c1c000956492f

😎 Browse the preview: https://deploy-preview-4683--typescript-eslint.netlify.app

@dependabot
chore: Bump @swc/core from 1.2.154 to 1.2.155
29e173c 
Bumps [@swc/core](https://github.com/swc-project/swc) from 1.2.154 to 1.2.155.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
- [Commits](swc-project/swc@v1.2.154...v1.2.155)

---
updated-dependencies:
- dependency-name: "@swc/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swc/core-1.2.155 branch from 3653efb to 29e173c Compare March 14, 2022 19:06
@bradzacher
Copy link
Member

bradzacher commented Mar 15, 2022 •
edited
Loading

cc @JoshuaKGoldberg

All the files failed with:

Test suite failed to run

    /home/runner/work/typescript-eslint/typescript-eslint/packages/typescript-estree/src/ts-estree/ts-nodes.ts: No element indexed by 0

      at ArraySet_at [as at] (../../node_modules/@babel/core/node_modules/source-map/lib/array-set.js:109:9)
      at BasicSourceMapConsumer.<anonymous> (../../node_modules/@babel/core/node_modules/source-map/lib/source-map-consumer.js:143:67)
          at Array.map (<anonymous>)
      at BasicSourceMapConsumer.SourceMapConsumer_eachMapping [as eachMapping] (../../node_modules/@babel/core/node_modules/source-map/lib/source-map-consumer.js:142:14)
      at buildMappingData (../../node_modules/@babel/core/lib/transformation/file/merge-map.js:[145](https://github.com/typescript-eslint/typescript-eslint/runs/5543066614?check_suite_focus=true#step:9:145):12)
      at mergeSourceMap (../../node_modules/@babel/core/lib/transformation/file/merge-map.js:19:17)
      at generateCode (../../node_modules/@babel/core/lib/transformation/file/generate.js:72:39)
      at run (../../node_modules/@babel/core/lib/transformation/index.js:53:33)
          at run.next (<anonymous>)
      at transform (../../node_modules/@babel/core/lib/transform.js:25:41)

seems like this bump causes a bug in babel?
That's super weird because packages/typescript-estree/src/ts-estree/ts-nodes.ts is a types-only file

I'll try rerunning the tests.

@JoshuaKGoldberg
Copy link
Member

Very weird. It all passes on my machine...

@codecov
Copy link

codecov bot commented Mar 20, 2022 •
edited
Loading

Codecov Report

Merging #4683 (33760f1) into main (b5b5f41) will increase coverage by 0.57%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main    #4683      +/-   ##
==========================================
+ Coverage   92.14%   92.71%   +0.57%     
==========================================
  Files         349      186     -163     
  Lines       11634    10095    -1539     
  Branches     3376     3183     -193     
==========================================
- Hits        10720     9360    -1360     
+ Misses        646      497     -149     
+ Partials      268      238      -30
Flag Coverage Δ
unittest 92.71% <96.29%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert-comments.ts 100.00% <ø> (ø)
...s/eslint-plugin/src/rules/prefer-optional-chain.ts 94.21% <95.45%> (+0.27%) ⬆️
...int-plugin/src/rules/consistent-type-assertions.ts 88.88% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/member-ordering.ts 95.71% <100.00%> (-1.41%) ⬇️
...ges/typescript-estree/src/create-program/shared.ts 89.79% <100.00%> (ø)
packages/typescript-estree/src/ts-estree/index.ts 57.14% <0.00%> (-9.53%) ⬇️
packages/eslint-plugin/src/util/astUtils.ts 84.21% <0.00%> (-4.03%) ⬇️
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 92.85% <0.00%> (-3.58%) ⬇️
packages/eslint-plugin/src/rules/comma-dangle.ts 93.33% <0.00%> (-2.23%) ⬇️
... and 278 more

@JoshuaKGoldberg
Copy link
Member

...huh. @bradzacher @JamesHenry I wonder if the error was some caching fluke? If so maybe it's also in the area of #4655 and/or #4657? 🤷

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9672905 into main Mar 20, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the dependabot/npm_and_yarn/swc/core-1.2.155 branch March 20, 2022 17:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradzacher @JoshuaKGoldberg