Skip to content

fix(eslint-plugin): [consistent-type-assertions] enforce assertionStyle for const assertions #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

fix(eslint-plugin): [consistent-type-assertions] enforce assertionStyle for const assertions #4685

merged 1 commit into from
Mar 18, 2022

Conversation

gtkatakura
Copy link
Contributor

@gtkatakura gtkatakura commented Mar 14, 2022 •
edited
Loading

PR Checklist

Overview

  • Enables the consistent-type-assertions rule enforces the assertionStyle (as and angle-bracket) for const too

@nx-cloud
Copy link

nx-cloud bot commented Mar 14, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 9a9d516. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @gtkatakura!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 9a9d516

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/622f9cd18f974700091c3dd3

😎 Browse the preview: https://deploy-preview-4685--typescript-eslint.netlify.app

@bradzacher bradzacher added the bug Something isn't working label Mar 15, 2022
@bradzacher bradzacher changed the title fix: enables assertionStyle as/angle-bracket works for const too fix(eslint-plugin): [consistent-type-assertions] enforce assertionStyle for const assertions Mar 18, 2022
bradzacher
bradzacher approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this!

@bradzacher bradzacher merged commit 8ec05be into typescript-eslint:main Mar 18, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 23, 2022
Update typescript-eslint monorepo to v5.16.0 (#1236)
1d3a4ef 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.15.0` -> `5.16.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.15.0/5.16.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.15.0` -> `5.16.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.15.0/5.16.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.16.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5160-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5150v5160-2022-03-21)

[Compare Source](typescript-eslint/typescript-eslint@v5.15.0...v5.16.0)

##### Bug Fixes

-   **eslint-plugin:** \[consistent-type-assertions] enforce assertionStyle for `const` assertions ([#&#8203;4685](typescript-eslint/typescript-eslint#4685)) ([8ec05be](typescript-eslint/typescript-eslint@8ec05be))

##### Features

-   **eslint-plugin:** \[prefer-optional-chain] support logical with empty object ([#&#8203;4430](typescript-eslint/typescript-eslint#4430)) ([d21cfe0](typescript-eslint/typescript-eslint@d21cfe0))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.16.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5160-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5150v5160-2022-03-21)

[Compare Source](typescript-eslint/typescript-eslint@v5.15.0...v5.16.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1236
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[consistent-type-assertions] assertionStyle doesn't enforces <const> case
2 participants
@gtkatakura @bradzacher