chore: replace deprecated String.prototype.substr() #4693
Conversation
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated. Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
|
Thanks for the PR, @CommanderRoot! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
|
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: af08bdf 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6232e1d61887a800093aaba9 😎 Browse the preview: https://deploy-preview-4693--typescript-eslint.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #4693 +/- ##
==========================================
- Coverage 92.14% 92.13% -0.01%
==========================================
Files 349 347 -2
Lines 11634 11627 -7
Branches 3376 3376
==========================================
- Hits 10720 10713 -7
Misses 646 646
Partials 268 268
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.