feat(eslint-plugin): add new 'strict' config #4706

JoshuaKGoldberg · 2022-03-21T14:45:48Z

PR Checklist

Addresses an existing issue: fixes Create a "strict" config between "recommended-requiring-type-checking" and "all" #4648
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Adds a new 'strict' level for the recommended metadata for rules. It indicates to include the rule in a new plugin:@typescript-eslint/strict config.

~~Putting this PR up now as a draft as reference for #4648 before fleshing out docs.~~ ✅

nx-cloud · 2022-03-21T14:45:50Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit be77517. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-03-21T14:45:53Z

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-03-21T14:45:55Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`be77517`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62818e854c97ba00084a725e
😎 Deploy Preview	https://deploy-preview-4706--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2022-04-04T00:57:41Z

Codecov Report

Merging #4706 (be77517) into main (77e15a9) will increase coverage by 1.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4706      +/-   ##
==========================================
+ Coverage   92.64%   94.08%   +1.44%     
==========================================
  Files         190      161      -29     
  Lines       10251     8559    -1692     
  Branches     3249     2770     -479     
==========================================
- Hits         9497     8053    -1444     
+ Misses        502      285     -217     
+ Partials      252      221      -31

Flag	Coverage Δ
unittest	`94.08% <100.00%> (+1.44%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts	`97.18% <ø> (ø)`
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/rules/ban-types.ts	`100.00% <ø> (ø)`
...t-plugin/src/rules/class-literal-property-style.ts	`100.00% <ø> (ø)`
...lugin/src/rules/consistent-indexed-object-style.ts	`92.06% <ø> (ø)`
...int-plugin/src/rules/consistent-type-assertions.ts	`88.88% <ø> (ø)`
...nt-plugin/src/rules/consistent-type-definitions.ts	`97.29% <ø> (ø)`
packages/eslint-plugin/src/rules/dot-notation.ts	`96.29% <ø> (ø)`
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`98.41% <ø> (ø)`
...lugin/src/rules/no-confusing-non-null-assertion.ts	`82.60% <ø> (ø)`
... and 57 more

docs/linting/PRESETS.md

packages/eslint-plugin/docs/rules/TEMPLATE.md

packages/eslint-plugin/src/configs/strict.ts

bradzacher

LGTM!

packages/eslint-plugin/docs/rules/TEMPLATE.md

bradzacher · 2022-05-15T22:10:11Z

feel free to admin merge once you've got this finalised - i'm happy with what you've got!

JoshuaKGoldberg · 2022-05-15T23:10:40Z

My main hesitation against pushing this is that we don't have a blog to nicely announce it on yet (#4957) 😂. But that's not a good reason. We can always posthumously write a blog post for this PR.

JoshuaKGoldberg · 2022-05-17T14:49:01Z

packages/eslint-plugin/tools/generate-configs.ts

+  extends: [
+    ...EXTENDS,
+    './configs/recommended',
+    './configs/recommended-requiring-type-checking',


Oh hey I think I'd meant to leave this out.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.23.0/5.25.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.23.0/5.25.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17) [Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0) ##### Bug Fixes - **eslint-plugin:** \[typedef] stop enforcing rule for assignment expressions ([#4958](typescript-eslint/typescript-eslint#4958)) ([04a216c](typescript-eslint/typescript-eslint@04a216c)) - **eslint-plugin:** strict config should not extend recommended ([#5005](typescript-eslint/typescript-eslint#5005)) ([05d71c2](typescript-eslint/typescript-eslint@05d71c2)) - **website:** correct Presets link to be Configs ([#5004](typescript-eslint/typescript-eslint#5004)) ([e18e91c](typescript-eslint/typescript-eslint@e18e91c)) ##### Features - **eslint-plugin:** \[no-empty-function] new allow option overrideMethods ([#4923](typescript-eslint/typescript-eslint#4923)) ([13c05ae](typescript-eslint/typescript-eslint@13c05ae)) - **eslint-plugin:** deprecate `no-duplicate-imports` in favour of `import/no-duplicates` ([#4973](typescript-eslint/typescript-eslint#4973)) ([1d2e41a](typescript-eslint/typescript-eslint@1d2e41a)) - update to TypeScript 4.7-rc ([#4829](typescript-eslint/typescript-eslint#4829)) ([6fe783c](typescript-eslint/typescript-eslint@6fe783c)) ### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16) [Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0) ##### Bug Fixes - **eslint-plugin:** \[array-type] in fixer add missing parens for constructor types [#4756](typescript-eslint/typescript-eslint#4756) ([#4971](typescript-eslint/typescript-eslint#4971)) ([0377070](typescript-eslint/typescript-eslint@0377070)) ##### Features - **eslint-plugin:** Add BigInt object type to default ban-types list ([#4970](typescript-eslint/typescript-eslint#4970)) ([1867728](typescript-eslint/typescript-eslint@1867728)) - **eslint-plugin:** add new 'strict' config ([#4706](typescript-eslint/typescript-eslint#4706)) ([4a500b2](typescript-eslint/typescript-eslint@4a500b2)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17) [Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16) [Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1357 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

JoshuaKGoldberg added 2 commits March 21, 2022 10:08

feat: add new 'strict' config

7b05b84

chore: simplified strict to always be 'warn'

418577c

Merge branch 'main' into strict-config

792c751

JoshuaKGoldberg mentioned this pull request Mar 21, 2022

Create a "strict" config between "recommended-requiring-type-checking" and "all" #4648

Closed

JoshuaKGoldberg added 4 commits March 21, 2022 10:52

chore: missing | false

c17ad3e

test: update tests for new strictness

1707478

test: update .md file templates and docs.test.ts

9c0dbd6

chore: update configs.test.ts too

d741d55

JoshuaKGoldberg added 3 commits April 3, 2022 20:01

Merge branch 'main' into strict-config

903247f

chore: update website docs

b237870

Merge branch 'main' into strict-config

a4a7c45

JoshuaKGoldberg marked this pull request as ready for review April 8, 2022 17:43

bradzacher added the recommended-rules Discussion about recommended rule sets label Apr 8, 2022

bradzacher previously approved these changes Apr 9, 2022

View reviewed changes

docs/linting/PRESETS.md Outdated Show resolved Hide resolved

packages/eslint-plugin/docs/rules/TEMPLATE.md Outdated Show resolved Hide resolved

packages/eslint-plugin/src/configs/strict.ts Show resolved Hide resolved

packages/eslint-plugin/src/configs/strict.ts Show resolved Hide resolved

JoshuaKGoldberg mentioned this pull request Apr 12, 2022

[eslint-plugin] Breaking: enable type information for prefer-optional-chain #4820

Closed

JoshuaKGoldberg added 2 commits April 12, 2022 19:19

docs: add sub-list of configs to attributes

5131919

docs: unified configs readme and presets file

51b19d2

JoshuaKGoldberg dismissed bradzacher’s stale review via 5131919 April 12, 2022 23:20

JoshuaKGoldberg mentioned this pull request Apr 12, 2022

Add new issue template for changing recommended configs #4822

Closed

JoshuaKGoldberg added 5 commits April 12, 2022 19:41

Merge branch 'main'

cc23e5f

docs: finish trimming configs readme

48d7225

fix: sidebar.base.js

c9d67dc

fix: finish renaming presets to config

a5134bd

fix: configs docs id

009bc6d

JoshuaKGoldberg requested review from bradzacher and armano2 April 13, 2022 01:22

JoshuaKGoldberg added 2 commits April 12, 2022 21:23

fix: typo; not 'three'

789cab6

fix: tip colons

d577332

JoshuaKGoldberg mentioned this pull request Apr 17, 2022

[no-unreachable] and [no-unused-label] are handled inconsistently #4819

Closed

3 tasks

bradzacher previously approved these changes Apr 18, 2022

View reviewed changes

bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 22, 2022

JoshuaKGoldberg changed the title ~~feat: add new 'strict' config~~ feat(eslint-plugin): add new 'strict' config May 15, 2022

JoshuaKGoldberg commented May 15, 2022

View reviewed changes

packages/eslint-plugin/docs/rules/TEMPLATE.md Outdated Show resolved Hide resolved

JoshuaKGoldberg added 2 commits May 15, 2022 15:31

chore: replace heavy_check_mark with lock

3bebc55

Merge branch 'main'

3e8ed85

JoshuaKGoldberg dismissed bradzacher’s stale review via 3e8ed85 May 15, 2022 19:37

bradzacher previously approved these changes May 15, 2022

View reviewed changes

chore: mostly fixed up docs, probably one or two more things to do

0fe329e

JoshuaKGoldberg dismissed bradzacher’s stale review via 0fe329e May 15, 2022 22:54

JoshuaKGoldberg added 3 commits May 15, 2022 19:19

docs: method-signature-style period, more in configs.ts

9f9921c

docs: method-signature-style period, more in configs.ts; fix readmes

aa469d2

chore: passing configs.test.ts, docs.test.ts locally

be77517

JoshuaKGoldberg merged commit 4a500b2 into typescript-eslint:main May 16, 2022

JoshuaKGoldberg deleted the strict-config branch May 16, 2022 00:09

JoshuaKGoldberg mentioned this pull request May 17, 2022

Bug: resolving base config errors when enabling new strict preset #5001

Closed

4 tasks

JoshuaKGoldberg commented May 17, 2022

View reviewed changes

github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): add new 'strict' config #4706

feat(eslint-plugin): add new 'strict' config #4706

JoshuaKGoldberg commented Mar 21, 2022 •

edited

Loading

nx-cloud bot commented Mar 21, 2022 •

edited

Loading

typescript-eslint bot commented Mar 21, 2022

netlify bot commented Mar 21, 2022 •

edited

Loading

codecov bot commented Apr 4, 2022 •

edited

Loading

bradzacher left a comment

bradzacher commented May 15, 2022

JoshuaKGoldberg commented May 15, 2022

JoshuaKGoldberg May 17, 2022

feat(eslint-plugin): add new 'strict' config #4706

feat(eslint-plugin): add new 'strict' config #4706

Conversation

JoshuaKGoldberg commented Mar 21, 2022 • edited Loading

PR Checklist

Overview

nx-cloud bot commented Mar 21, 2022 • edited Loading

☁️ Nx Cloud Report

typescript-eslint bot commented Mar 21, 2022

netlify bot commented Mar 21, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

codecov bot commented Apr 4, 2022 • edited Loading

Codecov Report

bradzacher left a comment

Choose a reason for hiding this comment

bradzacher commented May 15, 2022

JoshuaKGoldberg commented May 15, 2022

JoshuaKGoldberg May 17, 2022

Choose a reason for hiding this comment

JoshuaKGoldberg commented Mar 21, 2022 •

edited

Loading

nx-cloud bot commented Mar 21, 2022 •

edited

Loading

netlify bot commented Mar 21, 2022 •

edited

Loading

codecov bot commented Apr 4, 2022 •

edited

Loading