Skip to content

fix(visitor-keys): add missing visitor keys #4731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2022
Merged

fix(visitor-keys): add missing visitor keys #4731

merged 2 commits into from
Mar 31, 2022

Conversation

DMartens
Copy link
Contributor

PR Checklist

Overview

This adds the missing visitor keys mentioned in the issue #4724.

@nx-cloud
Copy link

nx-cloud bot commented Mar 25, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a3bf508. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @DMartens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 25, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a3bf508
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6242f4c7258bd20008ea3ab0
😎 Deploy Preview https://deploy-preview-4731--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher bradzacher added the bug Something isn't working label Mar 29, 2022
bradzacher
bradzacher requested changes Mar 29, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Some of these are good to go.

However we should remove the following:

  • TSModuleDeclaration - modifiers
  • TSEnumDeclaration - modifiers
  • TSInterfaceDeclaration - implements

I've filed #4759 - we should remove these from the AST in the next major.

the others are all valid bugs that are missing!

bradzacher
bradzacher approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding these!

@bradzacher bradzacher merged commit bb575a0 into typescript-eslint:main Mar 31, 2022
@DMartens DMartens deleted the add-missing-visitor-keys branch March 31, 2022 21:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing visitor keys
2 participants
@DMartens @bradzacher