Skip to content

fix(website): correct dark mode color regression #4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

fix(website): correct dark mode color regression #4771

merged 1 commit into from
Mar 31, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Mar 31, 2022 •
edited
Loading

Overview

i noticed that dark mode colors are not workign correctly after changes done in #4362

html:root has higher priority than html[data-theme='dark'] and it looks that dark mode overrides are no longer working correctly

image

and this should be

image

before fix:

image

after fix:

image

@armano2 armano2 added the package: website Issues related to the @typescript-eslint website label Mar 31, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 31, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c73f7b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint

This comment was marked as resolved.

Sign in to view
@netlify
Copy link

netlify bot commented Mar 31, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c73f7b1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6246176d50979200093d1622
😎 Deploy Preview https://deploy-preview-4771--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title fix(website): correct dark mode color regression introduced in #4362 fix(website): correct dark mode color regression Mar 31, 2022
@armano2
Copy link
Collaborator Author

armano2 commented Mar 31, 2022

its possible that this is not needed as #4692 fixes this issue

@armano2 armano2 closed this Mar 31, 2022
@armano2 armano2 deleted the chore/website-dark-mode-colors branch March 31, 2022 21:16
@armano2 armano2 mentioned this pull request Mar 31, 2022
Merged
3 tasks
@armano2 armano2 restored the chore/website-dark-mode-colors branch March 31, 2022 21:18
@armano2 armano2 reopened this Mar 31, 2022
bradzacher
bradzacher approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice good catch!

@bradzacher bradzacher merged commit 363fb0a into main Mar 31, 2022
@armano2 armano2 deleted the chore/website-dark-mode-colors branch April 1, 2022 00:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
package: website Issues related to the @typescript-eslint website
Projects
No open projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher